Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] TypeError: this.stopExclusion.catch is not a function #1031

Closed
4 of 7 tasks
andras-tim opened this issue Apr 10, 2021 · 1 comment · Fixed by #1036
Closed
4 of 7 tasks

[bug] TypeError: this.stopExclusion.catch is not a function #1031

andras-tim opened this issue Apr 10, 2021 · 1 comment · Fixed by #1036
Assignees
Labels
bug Something isn't working

Comments

@andras-tim
Copy link

andras-tim commented Apr 10, 2021

Version

Checklist:

  • I am not using HomeAssistant. Or: a developer has told me to come here.
  • I have checked the troubleshooting section and my problem is not described there.
  • I have read the changelog problem was not mentioned there.

Build/Run method

  • Docker
  • PKG
  • Snap package
  • Manually built (git clone - npm install - npm run build )

zwavejs2mqtt: 3.2.0
zwave-js: 7.1.1

Describe the bug

I tried to click on Stop exclusion when the counting down stuck on 0 s. But after that the whole daemon disappeared:

2021-04-10 13:23:37.545 INFO ZWAVE: Calling api startExclusion with args: [ [length]: 0 ]
2021-04-10 13:23:37.558 INFO ZWAVE: Controller status: Exclusion started
2021-04-10 13:23:37.559 INFO ZWAVE: Success zwave api call startExclusion { success: true, message: 'Success zwave api call', result: true }
TypeError: this.stopExclusion.catch is not a function
    at Timeout._onTimeout (/usr/src/app/lib/ZwaveClient.js:2283:37)
    at listOnTimeout (node:internal/timers:557:17)
    at processTimers (node:internal/timers:500:7)

To Reproduce

Steps to reproduce the behavior:

  1. Start excluding a node
  2. Wait for timeout
  3. The exclusion will not stop properly, because the counter stuck on 0s
  4. Try to close that with Stop button
  5. And you get this error message

Expected behavior

  • The counting down stops properly
  • The Stop button doesn't kill the daemon with a type error

Additional context

In general, I use HA, but when I add/remove node I always turn off that to avoid unwanted states/nodes... e.g. when I add a new node, I always rename that, but the HA remembers the original ids...

zwavejs_1.log

Update1

You should not do magic for reproduction:

  1. Start the exclusion
  2. Wait the counting down

I bisected the bug and the zwavejs2mqtt: 3.0.3, zwave-js: 7.0.1 was the first bad version.

@andras-tim
Copy link
Author

thx for the fast fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants