[bug] Configuration params inputs #1758
Assignees
Labels
bug
Something isn't working
Comments
Humm strange, when you send -20 do you see a log in console that says -20 is received? It could be that the device is refusing the value and so it reports 0. Needs logs
The custom chip is there because them have a list of supported values and
Them are set, check here. If you are interested to check the logic used to render inputs check them here: https://github.com/zwave-js/zwavejs2mqtt/blob/master/src/components/ValueId.vue
I don't understand what you mean here. If unit is % the value to insert will be from 0-100% 😕 |
2-3. Ok, but number of supported values is always one, so there is no point to use v-combobox with integer, it is not any kind of list. Maybe I do not understand something right. Looking at ValueId.vue component it would be ok if it jump into v-if="!value.list && value.type === 'number'". Why does generates value.list && value.allowManualEntry ? ..maybe this is the right question
If user want to change offset to plus 6% he have to enter value 6 ( as using % units) or 60 ( as using integers )? |
Could you send me a dump of that node? I would like to see the valueIds array to check the props
This really depends on your device, I mean what you see there is what I receive from zwavejs that is declared in zwavejs devices config database, it could be that there is a typo in docs and maybe they have set the unit to % but the input value is in decimals (or viceversa). To fix that just write here the device id and @blhoward2 or @AlCalzone could give it a check |
Our config files merely mirror what the devices expect. A lot devices have config params like this where a value of 60 means 6%, so we added a multiplier into the unit string to at least show this somewhere. I'm not very happy about it, but there are more important issues at the moment. If you can't wait, feel free to provide a PR to https://github.com/zwave-js/node-zwave-js adding support for a proper |
|
Ad.1 There is error in device documentation. I will send fix for it. I was trying set -20 to param that do not support negative values, due to this bug in doc. Never mind, and sorry for taking time on that. Ad.4 Thank You for explanation. I did not consider that such change can affect existing inconsistent config files. Ad.2-3 While You look at this please also help me understand why device is have security set to None, while documentation says that this device use 700chip and support |
Please make a driver log of a re-interview, loglevel |
|
Not to many debug logs, but here |
|
Ok I may have found the problem here: {
"id": "3-112-0-8",
"nodeId": 3,
"commandClass": 112,
"commandClassName": "Configuration",
"property": 8,
"propertyName": "Humidity Offset Value",
"type": "number",
"readable": true,
"writeable": true,
"label": "Humidity Offset Value",
"default": 0,
"stateless": false,
"min": -120,
"max": 120,
"unit": "0.1 %",
"list": true,
"allowManualEntry": true,
"states": [],
"value": 1,
"lastUpdate": 1632840352523,
"newValue": 1
},Seems that states are reported as an empty array and this makes me think it's a list value. Let me submit a fix for this @AlCalzone Just to know, did you changed something that makes zwaveValueMeta return an empty record for states? I noticed this problem too but wasn't working like that |
|
The states problem has been fixed on master, reopening this for the others |
Not that I know of - especially not an empty array. TypeScript would shout really loud if I did that. |
|
Nope sorry, them are |
|
Do you have an example? |
|
Seems to happen only with configuration valueIds BTW not a big deal is fixed now |
|
Which ones? If this is something on my end, I'd like to fix it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Version
Build/Run method
Zwavejs2Mqtt version: 5.7.0
Z-Wave JS version: 8.4.0
Describe the bug
Using this device as reference I found that:
I do believe that negative values are not supported well. Param 7 and 8 can be set from -120 to 120 (this is calibration value and have "unsigned": false param set. When I set -20 it is reporting that 0 is set.
html input elements are quite a mess. I totally do no understand why there is 'custom' chip, and select element in input where should be only input type=number
input type="numer" do have their min max step params. Make use of it. Those params are on device conf file
Unit is confusing. When I can set humidity calibration value from -12% to 12% with 0.1% step I should be able write 0.6%. And vue should translate it to 60. Now I have to enter '60'
The text was updated successfully, but these errors were encountered: