Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Protection values not refreshed #1971

Closed
4 of 7 tasks
mdegroux opened this issue Nov 18, 2021 · 4 comments · Fixed by #1972
Closed
4 of 7 tasks

[bug] Protection values not refreshed #1971

mdegroux opened this issue Nov 18, 2021 · 4 comments · Fixed by #1972
Assignees

Comments

@mdegroux
Copy link

Version

Checklist:

  • I am not using Home Assistant. Or: a developer has told me to come here.
  • I have checked the troubleshooting section and my problem is not described there.
  • I have read the changelog and my problem is not mentioned there.

Build/Run method

  • Docker
  • PKG
  • Snap package
  • Manually built (git clone - yarn install - yarn run build )

Zwavejs2Mqtt version: 5.11.0
Z-Wave JS version: 8.7.5

Describe the bug

On a Fibaro FGD-212 dimmer, I use protection commands to prevent using the physical switch the night (thank you children ;) )
When I change the value in the control panel (or from mqtt), the change is effectuve but I have the old value

To Reproduce

I've made a screen recording of the reproduction: https://www.screencast.com/t/aX5b6cZFJ

Expected behavior

When I change the protection, I want to see the new value

Additional context

I have attached log files.
Nota, in the logs, I do the counter than in the video
In the video, I try to set No Operation Possible
In the log I try to set [Unprotected]
zwavejs_2021-11-18.log
zwavejs2mqtt_2021-11-18.log

@robertsLando
Copy link
Member

If the value isn't updated It means I don't receive a value updated event. This could happen when the device isn't reporting it to zwave and the reason could be on device configurtations or a bug in device firmware.

cc @AlCalzone

@mdegroux
Copy link
Author

An additional information, before I was on OZW 1.4 and when I was changeng the protection, I had the new new value

@AlCalzone
Copy link
Member

Hm, seems like that value is actually not refreshed.

@AlCalzone AlCalzone transferred this issue from zwave-js/zwave-js-ui Nov 18, 2021
@AlCalzone AlCalzone self-assigned this Nov 18, 2021
@AlCalzone AlCalzone transferred this issue from zwave-js/node-zwave-js Nov 18, 2021
@AlCalzone
Copy link
Member

This is not actually a driver bug. There are several non-critical values that aren't refreshed after a SET and have to be assumed to be successfully set.

@robertsLando setValue updates the value in the Value DB but does not emit an event because it would spam unnecessary updates. After all the application knows which value it just set.
If the setValue call resolves to true, you need to update the value in your cache yourself. You might still get an updated value afterwards, but don't rely on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants