Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: The ui should limit the number of health check rounds according to the backend limits and show errors reported by the backend #2234

Closed
3 tasks
darkbasic opened this issue Feb 3, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@darkbasic
Copy link
Contributor

Checklist

  • I am not using Home Assistant. Or: a developer has told me to come here.
  • I have checked the troubleshooting section and my problem is not described there.
  • I have read the changelog and my problem is not mentioned there.

Deploy method

Manually built (git clone - yarn build - yarn install

Zwavejs2Mqtt version

git master

ZwaveJS version

bundled

Describe the bug

2022-02-03 14:56:45.419 INFO ZWAVE: Calling api checkLifelineHealth with args: [ 83, 50, [length]: 2 ]
2022-02-03 14:56:45.428 INFO ZWAVE: The number of health check rounds must be between 1 and 10! (ZW0322) checkLifelineHealth undefined

zwavejs-ui-health-check-rounds

Backend limits the rounds between 1 and 10, while the ui doesn't.
When the backend throws to inform the user the ui doesn't report the error message.

To Reproduce

See bug description.

Expected behavior

UI reports error messages.
UI limits the max rounds to 10.

Additional context

No response

@darkbasic darkbasic added the bug Something isn't working label Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant