Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): rearrange table columns #534

Merged
merged 3 commits into from
Feb 10, 2021
Merged

feat(ui): rearrange table columns #534

merged 3 commits into from
Feb 10, 2021

Conversation

ahochsteger
Copy link
Collaborator

This PR allows to rearrange the columns of the nodes table by dragging them around within the columns selection menu (ID is moved to 2nd column in this screenshot):
image

@robertsLando
Copy link
Member

Love this! @ahochsteger

robertsLando
robertsLando previously approved these changes Feb 10, 2021
Copy link
Member

@robertsLando robertsLando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some nits :)

src/components/nodes-table/index.vue Show resolved Hide resolved
src/components/nodes-table/index.vue Outdated Show resolved Hide resolved
src/modules/ManagedItems.js Show resolved Hide resolved
@coveralls
Copy link

Pull Request Test Coverage Report for Build 554057566

  • 0 of 49 (0.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.04%) to 19.852%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/nodes-table/nodes-table.js 0 2 0.0%
src/modules/ManagedItems.test.js 0 6 0.0%
src/modules/ManagedItems.js 0 41 0.0%
Totals Coverage Status
Change from base Build 553960379: -0.04%
Covered Lines: 1996
Relevant Lines: 10308

💛 - Coveralls

Copy link
Member

@robertsLando robertsLando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 GG @ahochsteger

@robertsLando robertsLando changed the title feat: rearrange table columns feat(ui): rearrange table columns Feb 10, 2021
@robertsLando
Copy link
Member

If you are done here, feel free to squash and merge :)

@ahochsteger ahochsteger enabled auto-merge (squash) February 10, 2021 08:58
@ahochsteger ahochsteger merged commit d6cd9ec into master Feb 10, 2021
@ahochsteger ahochsteger deleted the order-columns branch February 10, 2021 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants