Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: https support #535

Merged
merged 6 commits into from
Feb 10, 2021
Merged

feat: https support #535

merged 6 commits into from
Feb 10, 2021

Conversation

robertsLando
Copy link
Member

@robertsLando robertsLando commented Feb 10, 2021 •
edited

With this PR by using HTTPS env var will be possible to start the server with https instead of http.

Server cert and key will be auto generated and stored on store directory using node pem

cc @jmgiaever

ref #479

@robertsLando robertsLando mentioned this pull request Feb 10, 2021
Closed
@coveralls
Copy link

coveralls commented Feb 10, 2021 •
edited

Pull Request Test Coverage Report for Build 554677112

  • 0 of 88 (0.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 19.705%
Changes Missing Coverage Covered Lines Changed/Added Lines %
build/webpack.dev.conf.js 0 1 0.0%
config/index.js 0 6 0.0%
app.js 0 81 0.0%
Totals Coverage Status
Change from base Build 554676500: -0.1%
Covered Lines: 1996
Relevant Lines: 10386
💛 - Coveralls

@robertsLando robertsLando merged commit 346d638 into master Feb 10, 2021
@robertsLando robertsLando deleted the https branch February 10, 2021 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahochsteger ahochsteger Awaiting requested review from ahochsteger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@robertsLando @coveralls