Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hass): improved climates discovery #692

Merged
merged 11 commits into from
Feb 23, 2021
Merged

fix(hass): improved climates discovery #692

merged 11 commits into from
Feb 23, 2021

Conversation

varet80
Copy link
Collaborator

@varet80 varet80 commented Feb 22, 2021

This PR fixes climate thermostats (like Danfoss LC-13).

Fixes #607

@zwave-js-assistant
Copy link

🚧 It seems like this PR has lint errors 🚧

I should be able to fix them for you. If you want me to, just comment
@zwave-js-bot fix lint

@varet80 varet80 changed the title Fix: Not all climates been discovered, especially when temperature feedback is missing fix: not all climates been discovered, especially when temperature feedback is missing Feb 22, 2021
@coveralls
Copy link

coveralls commented Feb 22, 2021

Pull Request Test Coverage Report for Build 591926903

  • 0 of 12 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 19.228%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/Gateway.js 0 12 0.0%
Totals Coverage Status
Change from base Build 589619180: -0.2%
Covered Lines: 2006
Relevant Lines: 10705

💛 - Coveralls

lib/Gateway.js Outdated Show resolved Hide resolved
lib/Gateway.js Outdated Show resolved Hide resolved
lib/Gateway.js Outdated Show resolved Hide resolved
varet80 and others added 3 commits February 23, 2021 09:27
Co-authored-by: Daniel Lando <daniel.sorridi@gmail.com>
Co-authored-by: Daniel Lando <daniel.sorridi@gmail.com>
Co-authored-by: Daniel Lando <daniel.sorridi@gmail.com>
Copy link
Member

@robertsLando robertsLando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robertsLando robertsLando changed the title fix: not all climates been discovered, especially when temperature feedback is missing fix(hass): improved climates discovery Feb 23, 2021
@robertsLando robertsLando merged commit 1c60355 into master Feb 23, 2021
@robertsLando robertsLando deleted the fix-607 branch February 23, 2021 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[question] Danfoss LC13 not discovering all values
3 participants