Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): moved Value Refresh button to right on NodeDetails #1213

Merged
merged 2 commits into from May 13, 2021
Merged

fix(ui): moved Value Refresh button to right on NodeDetails #1213

merged 2 commits into from May 13, 2021

Conversation

Glenf
Copy link
Contributor

@Glenf Glenf commented May 13, 2021 •
edited by robertsLando

Preview of the change:
image

Fixes #1086

@robertsLando robertsLando changed the title feat(ui): Moved Value Refresh button to right on NodeDetails feat(ui): moved Value Refresh button to right on NodeDetails May 13, 2021
@robertsLando robertsLando changed the title feat(ui): moved Value Refresh button to right on NodeDetails fix(ui): moved Value Refresh button to right on NodeDetails May 13, 2021
robertsLando
robertsLando previously approved these changes May 13, 2021
View reviewed changes
Copy link
Member

@robertsLando robertsLando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once tests are OK. Thanks :)

@robertsLando robertsLando enabled auto-merge (squash) May 13, 2021 11:34
@zwave-js-assistant
Copy link

🚧 It seems like this PR has lint errors 🚧

I should be able to fix them for you. If you want me to, just comment
@zwave-js-bot fix lint

@robertsLando
Copy link
Member

@Glenf There are lint issues, please run yarn run lint-fix to fix them

auto-merge was automatically disabled May 13, 2021 13:28

Head branch was pushed to by a user without write access

@robertsLando robertsLando enabled auto-merge (squash) May 13, 2021 13:35
@coveralls
Copy link

Pull Request Test Coverage Report for Build 839006669

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 17.706%
Totals Coverage Status
Change from base Build 838274826: 0.0%
Covered Lines: 2020
Relevant Lines: 11774
💛 - Coveralls

@robertsLando robertsLando merged commit 332f811 into zwave-js:master May 13, 2021
@Glenf Glenf deleted the 1086-move-refresh-button-to-right branch May 13, 2021 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertsLando robertsLando robertsLando approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feat] Move Value Refresh button to right side of dropdown line
3 participants
@Glenf @robertsLando @coveralls