Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialog Windows are sometimes hidden behind main window #156 #233

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

valleyofblackpanther
Copy link
Contributor

Hi, @RazinShaikh as suggested I made a different PR for this issue,

  1. I have modified the show_error_msg function to accept a parent parameter. This parameter is then used to specify the parent of the QMessageBox so that the error message is modal to the parent.
  2. In each function that invokes show_error_msg, I ensured to pass the parent parameter. This means I added a parent argument to the signature of those functions if it's not already there. I did modification in the function import_diagram_from_file.

@RazinShaikh RazinShaikh merged commit fa7037f into zxcalc:master Feb 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants