Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Persian dictionary and language package #136

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

AmirHosseinKarimi
Copy link

No description provided.

@MrWook MrWook added the enhancement New feature or request label Aug 8, 2022
Copy link
Collaborator

@MrWook MrWook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a small issue in the readme but otherwise it looks fine 👍

Edit:
One more thing I have just seen.
The dictionaries should be generated inside this repo with the help of the ./data-scripts folder as descriped in the documentation https://zxcvbn-ts.github.io/zxcvbn/guide/languages/#add-a-new-language-package
Thats to ensure that the data that we received is not some random stuff. Unfortunately some countrie don't have this kind of data. Which means that the author of a language package collects the necessary data from different sources and host them on github

packages/languages/fa/README.md Outdated Show resolved Hide resolved
@AmirHosseinKarimi
Copy link
Author

Hi, @MrWook. Actually, I tried to build a Wikipedia dictionary via wikiextractor but it looks like it doesn't support Persian words. The final JSON file only contains English words.

As you can see:
image

But the source of words is trustable. They were extracted from verified sources.

@MrWook
Copy link
Collaborator

MrWook commented Aug 23, 2022

It's okey that the wikipedia script is not working, i will make it happen later.
But like i said i really want the sources inside this repo so that they can be generated with the ./data-scripts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants