Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix proposal for CLIENT_TIMEOUT value too low #11

Closed
SenTzu01 opened this issue Feb 28, 2024 · 4 comments
Closed

Fix proposal for CLIENT_TIMEOUT value too low #11

SenTzu01 opened this issue Feb 28, 2024 · 4 comments

Comments

@SenTzu01
Copy link

Please see below as reference for a fix in regards to Home Assistant Core issue #110140
I have been able to work around this until a fixture can be applied:
Workaround is to set timeout in the incomfortclient library to a sufficiently high value. Downside is this needs to be reapplied after every Home Assistant Core update.

docker exec command to achieve this is:

docker exec -it homeassistant sh "/bin/sed -i 's/CLIENT_TIMEOUT = 20/CLIENT_TIMEOUT = 300/g' /usr/local/lib/python3.12/site-packages/incomfortclient/__init__.py"
Alternatively one could create a shell command which can be triggered per the usual ways:

shell_command:
  fix_incomfort: /bin/sed -i 's/CLIENT_TIMEOUT = 20/CLIENT_TIMEOUT = 300/g' /usr/local/lib/python3.12/site-packages/incomfortclient/__init__.py
@NH-Networks
Copy link

If a timeout of 300 sec is needed to make it work.. then there is something seriously wrong..

Suggest to find real issue instead of this workaround

@SenTzu01
Copy link
Author

Agree, however, as I said in my previous post, still getting my head around HA, and Python. This could simply be a matter of slow hardware, or something more complicated. I'd like to continue to migrate my Home Automation to HA first, before digging in deeper. Just wanted to share my findings with the community so others get rid of the incomfort frustration :)

@zxdavb
Copy link
Collaborator

zxdavb commented Feb 29, 2024

If a timeout of 300 sec is needed to make it work.. then there is something seriously wrong..

I agree: I think this is OK as a workaround, but should not become part of the library.

@jbouwh
Copy link
Owner

jbouwh commented Jun 5, 2024

Closing this PR as it is not going to be implemented.

@jbouwh jbouwh closed this as not planned Won't fix, can't repro, duplicate, stale Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants