Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix show heating state when away #7

Closed
wants to merge 1 commit into from
Closed

Fix show heating state when away #7

wants to merge 1 commit into from

Conversation

phdelodder
Copy link
Contributor

This should fix #6

zxdavb
zxdavb reviewed Jan 26, 2021
View reviewed changes
custom_components/evohome_cc/climate.py
@@ -243,7 +245,10 @@ def hvac_mode(self) -> Optional[str]:
return
if self._evo_device.mode["system_mode"] == "heat_off":
return HVAC_MODE_OFF
if self._evo_device.mode["system_mode"] == "away":
if self.i_evo_device.mode["system_mode"] == "away":
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is i_evo_device.mode a typo?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it's a typo

@zxdavb
Copy link
Owner

zxdavb commented Jan 26, 2021

Have you confused CURRENT_HVAC_* with HVAC_MODE_*?

@phdelodder
Copy link
Contributor Author

Rethinking about it

@phdelodder phdelodder closed this Jan 27, 2021
@phdelodder phdelodder deleted the away_heat_demand branch February 20, 2021 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zxdavb zxdavb zxdavb left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When the preset mode is away, heat_demand is ignored
2 participants
@phdelodder @zxdavb