Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Arduino Due and the IDE 1.5.8 #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added support for Arduino Due and the IDE 1.5.8 #2

wants to merge 1 commit into from

Conversation

cmbsolutions
Copy link

Hi, i needed your library to work with the arduino Due. I managed to get it working for the due in de 1.5.8 IDE

I changed your lib so the due is supported (at least for the PPI16 SSD1289 parts)

Hope u can use it! :)

@zxfr
Copy link
Owner

zxfr commented Mar 20, 2015

Dear Maurice,

first of all thanks a lot for your interest in Pixels/Pixelmeister and for the code you contributed to the Project!

I am sorry for my impolite silence during the time - I was totally busy with tons of other things and found a timeframe to return to Pixels library only few days ago.

Right now I am incorporating your code into the library. Unfortunately in order to match some naming convention I cannot just merge in automatic mode, so I do everything manually step-by-step.

The only question I have is your trick with swap(). Why do you define for ARM a 3-parameter version of it?

Right now I have no hardware to test, but from theoretical perspective

#define swap(a, b) {int16_t buf = a; a = b; b = buf;}

looks quite correct and it compiles it with no problem.

Can you please shed some light on it?

Thanks in advance and kind regards,
Igor

On 21 Dec 2014, at 00:48 , Maurice notifications@github.com wrote:

Hi, i needed your library to work with the arduino Due. I managed to get it working for the due in de 1.5.8 IDE

I changed your lib so the due is supported (at least for the PPI16 SSD1289 parts)

Hope u can use it! :)

You can merge this Pull Request by running

git pull https://github.com/cmbsolutions/Pixels ArduinoDueSupport
Or view, comment on, or merge it at:

#2

Commit Summary

• Added support for Arduino Due and the IDE 1.5.8
File Changes

• M Pixels.cpp (21)
• M Pixels.h (63)
• M Pixels_PPI16.h (93)
• M Pixels_SSD1289.h (21)
Patch Links:

https://github.com/zxfr/Pixels/pull/2.patch
https://github.com/zxfr/Pixels/pull/2.diff

Reply to this email directly or view it on GitHub.

@cmbsolutions
Copy link
Author

hi igor,

i added the 3param swap because when i compile in ide 1.5.8 for arduino due
i get a parameter missing exception.

i looked in the utft library (because that does compile without errors) and
found the swap there has 3 params. when i added the trick it compiled
without errors.

if you like i can compile your version onto one of my due's to see if it
works

greets,

maurice
Op 20 mrt. 2015 16:31 schreef "zxfr" notifications@github.com:

Dear Maurice,

first of all thanks a lot for your interest in Pixels/Pixelmeister and for
the code you contributed to the Project!

I am sorry for my impolite silence during the time - I was totally busy
with tons of other things and found a timeframe to return to Pixels library
only few days ago.

Right now I am incorporating your code into the library. Unfortunately in
order to match some naming convention I cannot just merge in automatic
mode, so I do everything manually step-by-step.

The only question I have is your trick with swap(). Why do you define for
ARM a 3-parameter version of it?

Right now I have no hardware to test, but from theoretical perspective

#define swap(a, b) {int16_t buf = a; a = b; b = buf;}

looks quite correct and it compiles it with no problem.

Can you please shed some light on it?

Thanks in advance and kind regards,
Igor

On 21 Dec 2014, at 00:48 , Maurice notifications@github.com wrote:

Hi, i needed your library to work with the arduino Due. I managed to get
it working for the due in de 1.5.8 IDE

I changed your lib so the due is supported (at least for the PPI16
SSD1289 parts)

Hope u can use it! :)

You can merge this Pull Request by running

git pull https://github.com/cmbsolutions/Pixels ArduinoDueSupport
Or view, comment on, or merge it at:

#2

Commit Summary

• Added support for Arduino Due and the IDE 1.5.8
File Changes

• M Pixels.cpp (21)
• M Pixels.h (63)
• M Pixels_PPI16.h (93)
• M Pixels_SSD1289.h (21)
Patch Links:

https://github.com/zxfr/Pixels/pull/2.patch
https://github.com/zxfr/Pixels/pull/2.diff

Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on GitHub
#2 (comment).

@zxfr
Copy link
Owner

zxfr commented Mar 20, 2015

Thank you for the prompt reply!

On 20 Mar 2015, at 17:47 , Maurice notifications@github.com wrote:

hi igor,

i added the 3param swap because when i compile in ide 1.5.8 for arduino due
i get a parameter missing exception.

i looked in the utft library (because that does compile without errors) and
found the swap there has 3 params. when i added the trick it compiled
without errors.

if you like i can compile your version onto one of my due's to see if it
works

Yes, it would be great! I've already done a commit of a compilable version to Github and published a Pixelmeister update. Also there is a new example PolargraphUI (implements a simple UI framework) in the repository - I'm curious if it will work on DUE. If not, please do not invest much time into it.

Thank you again!
Igor

greets,

maurice
Op 20 mrt. 2015 16:31 schreef "zxfr" notifications@github.com:

Dear Maurice,

first of all thanks a lot for your interest in Pixels/Pixelmeister and for
the code you contributed to the Project!

I am sorry for my impolite silence during the time - I was totally busy
with tons of other things and found a timeframe to return to Pixels library
only few days ago.

Right now I am incorporating your code into the library. Unfortunately in
order to match some naming convention I cannot just merge in automatic
mode, so I do everything manually step-by-step.

The only question I have is your trick with swap(). Why do you define for
ARM a 3-parameter version of it?

Right now I have no hardware to test, but from theoretical perspective

#define swap(a, b) {int16_t buf = a; a = b; b = buf;}

looks quite correct and it compiles it with no problem.

Can you please shed some light on it?

Thanks in advance and kind regards,
Igor

On 21 Dec 2014, at 00:48 , Maurice notifications@github.com wrote:

Hi, i needed your library to work with the arduino Due. I managed to get
it working for the due in de 1.5.8 IDE

I changed your lib so the due is supported (at least for the PPI16
SSD1289 parts)

Hope u can use it! :)

You can merge this Pull Request by running

git pull https://github.com/cmbsolutions/Pixels ArduinoDueSupport
Or view, comment on, or merge it at:

#2

Commit Summary

• Added support for Arduino Due and the IDE 1.5.8
File Changes

• M Pixels.cpp (21)
• M Pixels.h (63)
• M Pixels_PPI16.h (93)
• M Pixels_SSD1289.h (21)
Patch Links:

https://github.com/zxfr/Pixels/pull/2.patch
https://github.com/zxfr/Pixels/pull/2.diff

Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on GitHub
#2 (comment).


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants