Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature suggestion: formatter #13

Closed
emicklei opened this issue Feb 2, 2017 · 5 comments
Closed

feature suggestion: formatter #13

emicklei opened this issue Feb 2, 2017 · 5 comments

Comments

@emicklei
Copy link

emicklei commented Feb 2, 2017

hi,

I am currently working on a proto definition file parser+formatter (https://github.com/emicklei/proto)
The protofmt tool can take a file and produce a formatted version (according to Google practices).

Would you be interested in adding this feature to your plugin? The tool is just a binary that needs to be called.

@zxh0
Copy link
Owner

zxh0 commented Feb 7, 2017

hi, thank you for this information, i will try it when i get some time ; )

@emicklei
Copy link
Author

some info https://code.visualstudio.com/blogs/2016/11/15/formatters-best-practices

let me know when I can be of any help

@mprobst
Copy link

mprobst commented Mar 1, 2017

clang-format has support for proto formatting and is commonly used inside of Google for that.

@zxh0
Copy link
Owner

zxh0 commented Apr 12, 2018

i finally decided to using clang-format, thank you @emicklei and @mprobst

@zxh0 zxh0 closed this as completed Apr 12, 2018
@nicolas-martin
Copy link

nicolas-martin commented May 17, 2018

I know this thread is dead, but is there a way to run a command on save? Prototool provides a formatter so you only need to to run prototool format dirOrProtoFiles -w

edit: saw you implemented it but for some reason the formatter doens't work for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants