undefined error if scanner is closed within scanDelay after a success… #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xtj7
force-pushed
the
undefined-error-on-immediate-close-after-successful-scan
branch
from
8e85585
to
c2c700d
Compare
…ful QR scan See the following issue for details: zxing-js#71
xtj7
force-pushed
the
undefined-error-on-immediate-close-after-successful-scan
branch
from
c2c700d
to
596854f
Compare
It was an alias used one time, there's no reason for a `protected` method here.
werthdavid
approved these changes
Apr 16, 2018
|
Looks fine to me, thanks for the work @xtj7 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ful QR scan
See the following issue for details: #71