Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pdf417 merge #10

Closed
wants to merge 8 commits into from
Closed

Pdf417 merge #10

wants to merge 8 commits into from

Conversation

graug
Copy link
Contributor

@graug graug commented May 3, 2013

The main changes are handling of ambiguous values, a few bug fixes, code cleanup, adding a Macro PDF417 test case and a few bits and pieces of documentation.

Regarding the new test case for Macro PDF417 decoding: It's a quick hack and in order to keep the changes in the common classes to a minimum, it copies a lot of code from other classes and methods. To avoid this, I'd have to make quite a few methods protected and non final and add a few hooks in AbstractBlackBoxTestCase . For the same reason I copied TestResult.java into the package. How do you feel about allowing subclasses more access to AbstractBlackBoxTestCase and TestResult?

Best regards,

Guenther

P.S.: A short list of what changed:

BarcodeMatrix:
replaced by two dimensional array of BarcodeValue

BarcodeValue:
Added comments, handling ambiguous values

BoundingBox:
Improve calculation and handling

Codeword:
toString method

DetectionResult:
Improved row numbering
applying std code format
toString method

DetectionResultColumn:
improved method names
toString method

DetectionResultRowIndicatorColumn:
Improved row numbering
Improved support for partial RI columns and missing/and or damaged start- and stop pattern

PDF417ScanningDecoder:
Improved bounding box handling
Improved support for partial RI columns and missing/and or damaged start- and stop pattern
Improved handling ambiguous values

Detector:
No instance needed anymore
applying std code format
fix off by one error on bottom coordinate detection

PDF417Common:
More common constants
added util method

PDF417Reader
Use static Detector method instead of creating instance

pdf417-2/24.bin
correct expected result

pdf417-4/*
test images and results for Macro PDF417 decoding

PDF41BlackBox4TestCase:
test case for Macro PDF417 decoding

TestResult
Copy of common test result

PDF417BlackBoxTestCase
updated expected results

@srowen
Copy link
Contributor

srowen commented May 25, 2013

I believe we've substantially merged this into the repo. We can close, no?

@graug
Copy link
Contributor Author

graug commented May 25, 2013

Sure, this can certainly be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants