core JAR Automatic-Module-Name: com.google.zxing #1155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Automatic-Module-Name entry of com.google.zxing to the core JAR for Java Platform Module System. See Issue zxing#1154
Codecov Report
@@ Coverage Diff @@
## master #1155 +/- ##
=========================================
Coverage 78.01% 78.01%
Complexity 4292 4292
=========================================
Files 254 254
Lines 14080 14080
Branches 2891 2891
=========================================
Hits 10985 10985
Misses 2264 2264
Partials 831 831Continue to review full report at Codecov.
|
srowen
approved these changes
Apr 8, 2019
msgilligan
deleted the
msgilligan-add-automatic-module-name-to-core-manifest
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
Automatic-Module-Nameentry ofcom.google.zxingto the core JAR for Java Platform Module System.
See Issue #1154
This contribution is my original work and I license the work to the project under the project's open source license.