Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrote Japanese help pages #14

Closed
wants to merge 6 commits into from
Closed

Conversation

taku0
Copy link

@taku0 taku0 commented May 24, 2013

Translated the help pages from English to Japanese.

By the way, the app name in Japanese was defined as "QRコードスキャナー" ("QR Code Scanner" in Japanese) in res/values-ja/strings.xml.
The second commit changes it to "Barcode Scanner". The third commit changes it to "バーコードスキャナー" ("Barcode Scanner" in Japanese).

If "QR Code Scanner" is your intention, I will rewrite the help pages. If you prefer "Barcode Scanner" but not "バーコードスキャナー", ignore the third commit.

If you merge the commits, please also update the app name in Google Play.

@srowen
Copy link
Contributor

srowen commented May 25, 2013

Thank you, I'm sure this is a strong improvement.

I think we should leave the app name as-is just because it has been named this way for years. I remember back in 2007 at Google, a native speaker advised us that "QR Code Scanner" would be most readily understood. Yes, it's not quite consistent with the title "Barcode Scanner".

So I will try to apply your first commit.

@srowen
Copy link
Contributor

srowen commented May 25, 2013

(PS it is OK to post pull requests here although in the end we work out of https://code.google.com/p/zxing/ primarily)

@taku0
Copy link
Author

taku0 commented May 25, 2013

I agree with him/her (the native speaker at Google). Scanning QR Codes is the most common use case in Japan.
Reverted the second and third commit. Updated help pages.

@srowen
Copy link
Contributor

srowen commented May 25, 2013

r2810 in Subversion integrates your first and last commit. Have a look, once it's pulled in to git.

@taku0
Copy link
Author

taku0 commented May 25, 2013

It looks good. There is no problem.

@zxing
Copy link
Collaborator

zxing commented May 25, 2013

Fixed in r2810.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants