Avoid decoding stacked row 1 of N independently #1693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srowen
approved these changes
Sep 15, 2023
srowen
reviewed
Sep 15, 2023
core/src/main/java/com/google/zxing/oned/rss/expanded/RSSExpandedReader.java
Show resolved
Hide resolved
|
@srowen I think this one's good now, let me know if you need anything else. Thanks! |
|
@srowen Thanks for the quick merges on these last few PRs! Fuzzing DataBar Expanded against Okapi was breaking within seconds prior to these fixes, but I can now run millions of tests without any issues, so it looks like it's much more robust now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When processing RSS Expanded stacked symbols, in some rare cases the first row processed looks like an independent single-row barcode based on checksum calculations. However, this is obviously not the case when the allowed finder pattern sequences are taken into account.
This PR adds a check to the finder pattern sequence as a last step before deciding to return the current (first processed) row as a fully, independently decoded barcode. I believe this also addresses a long-standing TODO in the code, now removed as part of this PR.
This PR includes a test which fails without the fix.