Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pdf417 changes #9

Closed
wants to merge 155 commits into from
Closed

pdf417 changes #9

wants to merge 155 commits into from

Conversation

smparkes
Copy link

@smparkes smparkes commented May 2, 2013

No description provided.

graug and others added 30 commits April 4, 2013 18:22
@graug
add eclipse meta data
4871bbf
@graug
add additional argument to only use selected barcodes
5a7ec3d
@graug
update expected results
70a841c
@graug
new test data
1809595
@graug
prevent NPE for compact PDF417 which only has 4 coordinates
4648427
@graug
work in progress for a new PDF417 decoder
8dca213
@graug
use FixedValueBinarizer
27bcd93
@graug
move commented out test data to separate unit test
125c351 
ensure that bit count adjustment for small counts never becomes 0
@graug
work in progress
b4864e1 
trying to get more reliable barcode row estimate
@graug
don't catch ArrayOutOfBoundsException
bf395e6
@graug
new version of scanning decoder
e830f6e 
now decodes the following test cases
PDF417/*.png: all
PDF417/*.png: all, except 17, 18 and 22
PDF417-3/*.png: all
@graug
work in progress
ab6e084 
implemented a new bitCount adjuster
now all test images are decoded properly
code needs cleanup, though
@graug
add myself as an author
c5faee2
@graug
first round of code cleanup
e9f4ffc
@graug
don't print the points
d62da39
@graug
adjust min and max codeword width
94d299c
@graug
take care of open TODOs
49c4b1e
@graug
start of integration of fixed value binarizer
7769ba7
@graug
sync with zxing main
5d4801c
@graug
Issue 1659 carry through metadata on multiple barcodes
e0dd43d 
git-svn-id: http://zxing.googlecode.com/svn/trunk@2619 59b500cc-1b3d-0410-9834-0bbf25fbcc57
@graug
c++ port of r2550
4936e6f 
git-svn-id: http://zxing.googlecode.com/svn/trunk@2621 59b500cc-1b3d-0410-9834-0bbf25fbcc57
@graug
C++ updates for r2574 and other java reconciliation
3646cf4 
git-svn-id: http://zxing.googlecode.com/svn/trunk@2622 59b500cc-1b3d-0410-9834-0bbf25fbcc57
@graug
c++ port of r2576
eb5a519 
git-svn-id: http://zxing.googlecode.com/svn/trunk@2623 59b500cc-1b3d-0410-9834-0bbf25fbcc57
@graug
c++ port of the relevant parts of r2581
dcede4d 
git-svn-id: http://zxing.googlecode.com/svn/trunk@2624 59b500cc-1b3d-0410-9834-0bbf25fbcc57
@graug
c++ port of r2585
2007335 
git-svn-id: http://zxing.googlecode.com/svn/trunk@2625 59b500cc-1b3d-0410-9834-0bbf25fbcc57
@graug
c++ port of r2592
fe2f9e6 
git-svn-id: http://zxing.googlecode.com/svn/trunk@2626 59b500cc-1b3d-0410-9834-0bbf25fbcc57
@graug
c++ port of r2595
4b4886d 
git-svn-id: http://zxing.googlecode.com/svn/trunk@2627 59b500cc-1b3d-0410-9834-0bbf25fbcc57
@graug
const-ness and iphone/objc fixes
ac81dc4 
git-svn-id: http://zxing.googlecode.com/svn/trunk@2628 59b500cc-1b3d-0410-9834-0bbf25fbcc57
@graug
correctly seperate args in url
d085a3e 
git-svn-id: http://zxing.googlecode.com/svn/trunk@2629 59b500cc-1b3d-0410-9834-0bbf25fbcc57
@graug
stringByReplacingOccurrencesOfString doesn't do what I thought it did
11f8635 
git-svn-id: http://zxing.googlecode.com/svn/trunk@2630 59b500cc-1b3d-0410-9834-0bbf25fbcc57
graug added 22 commits April 26, 2013 19:05
@graug
merge the remaining diffs
75edf45
@graug
meger one more file
391fed1
@graug
remove images to avoid merge conflicts
460c169
@graug
Merge remote-tracking branch 'zxing-main/http'
22bce7b
@graug
detector was returning bottomY coordinate one too high
ba25242
@graug
Merge remote-tracking branch 'zxing-main/http'
fce6ad8
@graug
Merge branch 'master' of https://github.com/graug/zxing.git
b761f12
@graug
Merge remote-tracking branch 'zxing-main/http'
2460380
@graug
merge changes from pdf417-dev branch
e9c0751
@graug
add corrected expect file
82986a5
@graug
adjust expected result counts
8565a60
@graug
public to pkg private
22a460a
@graug
reorder methods
5544c69
@graug
reformat
4016db1
@graug
remove logger
45e4b65
@graug
private constructor
9be172a
@graug
code cleanup and documentation
c618a65
@graug
updated test data
524a93c
@graug
add test case back for macroPdf417
682b3f0
@graug
limit the number of decoding tries for ambiguous value decoding
9ac147b
@graug
remove local test case
ff236b9
@graug
add comment
f84b0f3
@rpechayr
Copy link

rpechayr commented May 2, 2013

[useless comment] Never seen so many commits in a PR

Romain Pechayre
Sent with Sparrow (http://www.sparrowmailapp.com/?sig)

On Thursday, May 2, 2013 at 9:57 PM, Steven Parkes wrote:

You can merge this Pull Request by running
git pull https://github.com/smparkes/zxing master
Or view, comment on, or merge it at:
#9
Commit Summary
add eclipse meta data
add additional argument to only use selected barcodes
update expected results
new test data
prevent NPE for compact PDF417 which only has 4 coordinates
work in progress for a new PDF417 decoder
use FixedValueBinarizer
move commented out test data to separate unit test
work in progress
don't catch ArrayOutOfBoundsException
new version of scanning decoder
work in progress
add myself as an author
first round of code cleanup
don't print the points
adjust min and max codeword width
take care of open TODOs
start of integration of fixed value binarizer
sync with zxing main
Issue 1659 carry through metadata on multiple barcodes
c++ port of r2550
C++ updates for r2574 and other java reconciliation
c++ port of r2576
c++ port of the relevant parts of r2581
c++ port of r2585
c++ port of r2592
c++ port of r2595
const-ness and iphone/objc fixes
correctly seperate args in url
stringByReplacingOccurrencesOfString doesn't do what I thought it did
give user option of returning to zxing:// on cancel
clear redirect after use
remove relative include
reduce the insanity in iphone
typo
update/markdown the iphone readme
step towards making VS happy
work in progress for a new PDF417 decoder
use FixedValueBinarizer
move commented out test data to separate unit test
work in progress
new version of scanning decoder
comment out unused debugging method
test
test commit
apply lost changes
move test data to the correct dirs
revert whitespace changes
change from master repo was lost
remove bigger row number jumps in row indicator columns
add comment about improved row number adjustment idea
improve row number adjustment
adjust test case properly for multiple results
decoding result
add more test codewords
code cleanup
remove whitespace
prevent NPE for compact PDF417 which only has 4 coordinates
comment out unused debugging method
test
test commit
change from master repo was lost
Merge remote-tracking branch 'zxing-main/master'
Merge remote-tracking branch 'zxing-main/master'
first cut at detection without left row indicator column
Merge remote-tracking branch 'zxing-main/master'
use RRI if LRI is missing
add correctedErrorsCount to result
adjust authors
add rotation 180 degress implementation
default log level should be error
improve logging
use logger to print warning
implement getRow and setRow to make rotation 180 work
fix set blackpoint handling
fix nudging points to handle cases with negative values properly
change log level to info for result matrix
log level changes
adjust expected results count
replace system.err with log
switch to java7
replace system.out by log statement
change log level
change log format
use hybrid binarizer
more testcases
use hybrid binarizer
don't remove single pixel values
add null check for barcode value
don't return ambigous values
add different adjustment result generator
Merge remote-tracking branch 'zxing-main/master'
merge latest changes
merge changes
new testdata for macro pdf417
new test case for macro pdf417
detect multiple barcodes on a single image
fix returning result
set min height for detected barcode points
updated macro pdf417 testdata
fix mulitple handling
new testcase for macro pdf417
make test images a little smaller
shave off a few bits by using a higher compression ratio
code cleanup and comments
more cleanup and comments
add time logs
rename variable
small code cleanup
new test image for incomplete start and end pattern
improved handling for incomplete start and end columns
update local test data path
Japanese translation updates from asdf
Merge commit '641beae9ebd616ff1f7dd752e7c6d9ca9e3c06c9'
Merge commit 'd523ca6650fd825052b96f9525d64be0a33c13bb'
Merge commit 'b13ec91aabe461fc47f6e49e2556c188976023fd'
Merge commit 'd36eaa8e40a6fd87e387c707a8c5eb7c3f2ba3f0'
Merge commit 'ba33cbd1f468f6ba2ef8cb4b0caf6fbc5b22353f'
Merge commit 'f53471c7d9768a1d6ed273294d08df0dac6ad034'
Merge commit 'eb73e5af18e1773295888ad9e3fa49ef9f8e7af2'
Merge remote-tracking branch 'zxing-main/http'
add latest version from master
added .gitignore
change time measuring log to error level
apply changes
add correction from Sean
maxY position was one too high
remove expected txt test result
use last detected line as well
remove unused method
debug to devel
Merge remote-tracking branch 'zxing-main/http'
merge changes from zxing/master
merge the remaining diffs
meger one more file
remove images to avoid merge conflicts
Merge remote-tracking branch 'zxing-main/http'
detector was returning bottomY coordinate one too high
Merge remote-tracking branch 'zxing-main/http'
Merge branch 'master' of https://github.com/graug/zxing.git
Merge remote-tracking branch 'zxing-main/http'
merge changes from pdf417-dev branch
add corrected expect file
adjust expected result counts
public to pkg private
reorder methods
reformat
remove logger
private constructor
code cleanup and documentation
updated test data
add test case back for macroPdf417
limit the number of decoding tries for ambiguous value decoding
remove local test case
add comment

File Changes
A .classpath (https://github.com/zxing/zxing/pull/9/files#diff-0) (13)
A .project (https://github.com/zxing/zxing/pull/9/files#diff-1) (23)
A .settings/org.eclipse.jdt.core.prefs (https://github.com/zxing/zxing/pull/9/files#diff-2) (7)
A .settings/org.eclipse.wst.common.project.facet.core.xml (https://github.com/zxing/zxing/pull/9/files#diff-3) (4)
A bin/.gitignore (https://github.com/zxing/zxing/pull/9/files#diff-4) (1)
M core/src/com/google/zxing/pdf417/PDF417Common.java (https://github.com/zxing/zxing/pull/9/files#diff-5) (27)
M core/src/com/google/zxing/pdf417/PDF417Reader.java (https://github.com/zxing/zxing/pull/9/files#diff-6) (2)
D core/src/com/google/zxing/pdf417/decoder/BarcodeMatrix.java (https://github.com/zxing/zxing/pull/9/files#diff-7) (55)
M core/src/com/google/zxing/pdf417/decoder/BarcodeValue.java (https://github.com/zxing/zxing/pull/9/files#diff-8) (34)
M core/src/com/google/zxing/pdf417/decoder/BoundingBox.java (https://github.com/zxing/zxing/pull/9/files#diff-9) (34)
M core/src/com/google/zxing/pdf417/decoder/Codeword.java (https://github.com/zxing/zxing/pull/9/files#diff-10) (5)
M core/src/com/google/zxing/pdf417/decoder/DetectionResult.java (https://github.com/zxing/zxing/pull/9/files#diff-11) (128)
M core/src/com/google/zxing/pdf417/decoder/DetectionResultColumn.java (https://github.com/zxing/zxing/pull/9/files#diff-12) (29)
M core/src/com/google/zxing/pdf417/decoder/DetectionResultRowIndicatorColumn.java (https://github.com/zxing/zxing/pull/9/files#diff-13) (116)
M core/src/com/google/zxing/pdf417/decoder/PDF417ScanningDecoder.java (https://github.com/zxing/zxing/pull/9/files#diff-14) (263)
M core/src/com/google/zxing/pdf417/detector/Detector.java (https://github.com/zxing/zxing/pull/9/files#diff-15) (58)
M core/test/data/blackbox/pdf417-2/24.bin (https://github.com/zxing/zxing/pull/9/files#diff-16) (0)
A core/test/data/blackbox/pdf417-4/01-01.png (https://github.com/zxing/zxing/pull/9/files#diff-17) (0)
A core/test/data/blackbox/pdf417-4/01.bin (https://github.com/zxing/zxing/pull/9/files#diff-18) (0)
A core/test/data/blackbox/pdf417-4/02-01.png (https://github.com/zxing/zxing/pull/9/files#diff-19) (0)
A core/test/data/blackbox/pdf417-4/02-02.png (https://github.com/zxing/zxing/pull/9/files#diff-20) (0)
A core/test/data/blackbox/pdf417-4/02.bin (https://github.com/zxing/zxing/pull/9/files#diff-21) (0)
M core/test/src/com/google/zxing/pdf417/PDF417BlackBox2TestCase.java (https://github.com/zxing/zxing/pull/9/files#diff-22) (5)
A core/test/src/com/google/zxing/pdf417/PDF417BlackBox4TestCase.java (https://github.com/zxing/zxing/pull/9/files#diff-23) (260)
A core/test/src/com/google/zxing/pdf417/TestResult.java (https://github.com/zxing/zxing/pull/9/files#diff-24) (55)
A objc/cpp (https://github.com/zxing/zxing/pull/9/files#diff-25) (1)
D objc/cpp (https://github.com/zxing/zxing/pull/9/files#diff-26) (1)
D objc/examples/ios/bare/objc (https://github.com/zxing/zxing/pull/9/files#diff-27) (1)
A objc/examples/ios/bare/objc (https://github.com/zxing/zxing/pull/9/files#diff-28) (1)
D objc/examples/osx/bare/objc (https://github.com/zxing/zxing/pull/9/files#diff-29) (1)
A objc/examples/osx/bare/objc (https://github.com/zxing/zxing/pull/9/files#diff-30) (1)
D objc/examples/osx/demo/objc (https://github.com/zxing/zxing/pull/9/files#diff-31) (1)
A objc/examples/osx/demo/objc (https://github.com/zxing/zxing/pull/9/files#diff-32) (1)

Patch Links:
https://github.com/zxing/zxing/pull/9.patch
https://github.com/zxing/zxing/pull/9.diff

@smparkes
Copy link
Author

smparkes commented May 2, 2013

It's really only for review of someone else's changes (see comments on the group). The long commit list is an artifact of using merges rather than rebases.

@smparkes
Copy link
Author

smparkes commented May 3, 2013

See PR#10

@smparkes smparkes closed this May 3, 2013
@graug
Copy link
Contributor

graug commented May 3, 2013

I ditched my clone, created a new one and applied my changes. Not sure if pull requests are actually dealt with for zxing, as the main repo seems to be svn based. Anyways, this pull request can be deleted

@shlwang shlwang mentioned this pull request Dec 31, 2014
Closed
This was referenced May 14, 2015
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@smparkes @rpechayr @graug