Skip to content

Commit

Permalink
Use fixed-sized types (firebase#719)
Browse files Browse the repository at this point in the history
Should have caught this during review, but cpplint caught it
  • Loading branch information
wilhuff authored and zxu123 committed Jan 29, 2018
1 parent 6dc1373 commit 63a380b
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion Firestore/core/src/firebase/firestore/model/timestamp.cc
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ namespace firebase {
namespace firestore {
namespace model {

Timestamp::Timestamp(long seconds, int nanos)
Timestamp::Timestamp(int64_t seconds, int32_t nanos)
: seconds_(seconds), nanos_(nanos) {
FIREBASE_ASSERT_MESSAGE_WITH_EXPRESSION(
nanos >= 0, nanos >= 0, "timestamp nanoseconds out of range: %d", nanos);
Expand Down
12 changes: 6 additions & 6 deletions Firestore/core/src/firebase/firestore/model/timestamp.h
Original file line number Diff line number Diff line change
Expand Up @@ -43,22 +43,22 @@ class Timestamp {
* @param seconds the number of seconds since epoch.
* @param nanos the number of nanoseconds after the seconds.
*/
Timestamp(long seconds, int nanos);
Timestamp(int64_t seconds, int32_t nanos);

/** Returns a timestamp with the current date / time. */
static Timestamp Now();

long seconds() const {
int64_t seconds() const {
return seconds_;
}

int nanos() const {
int32_t nanos() const {
return nanos_;
}

private:
long seconds_;
int nanos_;
int64_t seconds_;
int32_t nanos_;
};

/** Compares against another Timestamp. */
Expand Down Expand Up @@ -91,4 +91,4 @@ inline bool operator==(const Timestamp& lhs, const Timestamp& rhs) {
} // namespace firestore
} // namespace firebase

#endif // FIRESTORE_CORE_SRC_FIREBASE_FIRESTORE_MODEL_FIELD_VALUE_H_
#endif // FIRESTORE_CORE_SRC_FIREBASE_FIRESTORE_MODEL_TIMESTAMP_H_

0 comments on commit 63a380b

Please sign in to comment.