fix(name): fix route crash for some ids

sometimes we don't get genres, causing the crash. fix https://codeberg.org/zyachel/libremdb/issues/20
zyachel · Oct 14, 2023 · e91c313 · e91c313
1 parent 5fa5e9e
commit e91c313
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 9 deletions.
diff --git a/src/interfaces/misc/rawName.ts b/src/interfaces/misc/rawName.ts
@@ -373,7 +373,7 @@ export default interface Name {
                       }>;
                     };
                   };
-                  titleGenres: {
+                  titleGenres?: {
                     genres: Array<{
                       genre: {
                         text: string;
@@ -525,7 +525,7 @@ export default interface Name {
                       }>;
                     };
                   };
-                  titleGenres: {
+                  titleGenres?: {
                     genres: Array<{
                       genre: {
                         text: string;
@@ -740,7 +740,7 @@ export default interface Name {
                     }>;
                   };
                 };
-                titleGenres: {
+                titleGenres?: {
                   genres: Array<{
                     genre: {
                       text: string;

diff --git a/src/utils/cleaners/name.ts b/src/utils/cleaners/name.ts
@@ -113,7 +113,7 @@ const cleanName = (rawData: RawName) => {
         avg: item.node.title.ratingsSummary.aggregateRating ?? null,
         numVotes: item.node.title.ratingsSummary.voteCount,
       },
-      genres: item.node.title.titleGenres.genres.map(genre => genre.genre.text),
+      genres: item.node.title.titleGenres?.genres.map(genre => genre.genre.text) ?? [],
 
       summary: {
         numEpisodes: item.node.summary.episodeCount ?? null,
@@ -133,10 +133,11 @@ const cleanName = (rawData: RawName) => {
           id: cat.titleTypeCategory.id,
           label: cat.titleTypeCategory.text,
         })),
-        genres: misc.creditSummary.genres.map(genre => ({
-          total: genre.total,
-          name: genre.genre.displayableProperty.value.plainText,
-        })),
+        genres:
+          misc.creditSummary.genres.map(genre => ({
+            total: genre.total,
+            name: genre.genre.displayableProperty.value.plainText,
+          })) ?? [],
       },
       released: getCredits(misc.releasedPrimaryCredits),
       // unreleased: getCredits<'unreleased'>(misc.unreleasedPrimaryCredits),
@@ -263,7 +264,7 @@ const getCredits = <T extends 'released' | 'unreleased' = 'released'>(
         numVotes: item.node.title.ratingsSummary.voteCount,
       },
       test: JSON.stringify(item.node.title),
-      genres: item.node.title.titleGenres.genres.map(genre => genre.genre.text),
+      genres: item.node.title.titleGenres?.genres.map(genre => genre.genre.text) ?? [],
       productionStatus: item.node.title.productionStatus.currentProductionStage.text,
 
       summary: {