Minor clean-up + version bump

zyantific · Oct 9, 2017 · 2646f5e · 2646f5e
1 parent dc88346
commit 2646f5e
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 19 deletions.
diff --git a/src/PluginConfig.hpp b/src/PluginConfig.hpp
@@ -25,8 +25,8 @@
 #define PLUGINCONFIG_HPP
 
 #define MAKE_PLUGIN_VERSION(maj, min, rev)  ((maj << 16) | (min << 8) | rev)
-#define PLUGIN_TEXTUAL_VERSION  "v1.4.1"
-#define PLUGIN_VERSION          MAKE_PLUGIN_VERSION(1, 4, 1)
+#define PLUGIN_TEXTUAL_VERSION  "v1.5"
+#define PLUGIN_VERSION          MAKE_PLUGIN_VERSION(1, 5, 0)
 
 #define PLUGIN_NAME             "IDASkins"
 

diff --git a/src/Settings.hpp b/src/Settings.hpp
@@ -33,9 +33,6 @@
 class Settings : public QSettings
 {
 public:
-    /**
-     * @brief   Default constructor.
-     */
     Settings();
     virtual ~Settings();
 public:

diff --git a/src/ThemeManifest.hpp b/src/ThemeManifest.hpp
@@ -32,6 +32,8 @@
 
 class ThemeManifest
 {
+    Q_DISABLE_COPY(ThemeManifest)
+
     QString m_themeName;
     QString m_themeAuthor;
     QString m_themeVersion;
@@ -41,31 +43,23 @@ class ThemeManifest
     ThemeManifest() {}
     ThemeManifest(const QString &manifestFilePath);
 public:
-    struct XInvalidManifest : public std::runtime_error
+    struct XInvalidManifest : std::runtime_error
     {
         XInvalidManifest(const char *what) : std::runtime_error(what) {}
     };
 public:
-    // NOTE: setters not required, yet. 
-    const QString& themeName() const                { return m_themeName;           }
-    void setThemeName(const QString &themeName)     { m_themeName = themeName;      }
-    const QString& themeAuthor() const              { return m_themeAuthor;         }
-    void setThemeAuthor(const QString &author)      { m_themeAuthor = author;       }
-    const QString& themeVersion() const             { return m_themeVersion;        }
-    void setThemeVersion(const QString &version)    { m_themeVersion = version;     }
-    const QString& themePreviewImage() const        { return m_themePreviewImage;   }
-    void setThemePreviewImage(const QString &image) { m_themePreviewImage = image;  }
-    const QString& themeNotes() const               { return m_themeNotes;          }
-    void setThemeNotes(const QString &notes)        { m_themeNotes = notes;         }
+    const QString& themeName        () const { return m_themeName;           }
+    const QString& themeAuthor      () const { return m_themeAuthor;         }
+    const QString& themeVersion     () const { return m_themeVersion;        }
+    const QString& themePreviewImage() const { return m_themePreviewImage;   }
+    const QString& themeNotes       () const { return m_themeNotes;          }
 public:
     /**
      * @brief   Parses a given manifest file.
      * @param   manifestFilePath    Full pathname of the manifest file.
      * @throws  XInvalidManifest    If manifest file is invalid.
      */
     void parseFile(const QString &manifestFilePath);
-
-    Q_DISABLE_COPY(ThemeManifest);
 };
 
 // ============================================================================================= //