relocation address error

[nblog]

samlpe:

ZyrexInstallInlineHook((void*)&CopyFileW, (const void*)&callback, &original);

for example:
kernel32.dll->CopyFileW
nop
nop
nop
jmp $-0xC

trampoline->code_buffer :

jmp 0x7752E597 ; error jmp

"jmp 0x7752E598" that's the right jump, It should be a calculation error.

[nblog]

ZyrexCalculateRelativeOffset(length, (ZyanUPointer)address,
address value error.

maybe like this.
#L568

        // Write opcode
        ZyanU8* address = (ZyanU8*)context->destination + context->bytes_written;
        ZyanUPointer ptr = (ZyanUPointer)address;
        if (opcode == 0xE9)
        {
            *address++ = 0xE9;
        } else
        {
            *address++ = 0x0F;
            *address++ = opcode;
        }

        // Write relative offset
        *(ZyanI32*)(address) = 
            ZyrexCalculateRelativeOffset(length, ptr,
                instruction->absolute_target_address);

[flobernd]

Thanks for reporting. I will have a look later. It’s very possible that the 32-bit hooking is still off a bit because I mainly tested on 64-bit for now.

A first stable version is expected to be released in the next two weeks.

[flobernd]

@nblog
I was not able to reproduce the problem on my local branch - but I already made some changes, so it might have been fixed in the meantime.

Probably going to push my local changes on the weekend after some cleaning.

[nblog]

I have tested the error still exists
The reason for the error is when you calculate the relative address
#L581 ZyrexCalculateRelativeOffset source_address = address
And you were address ++ at #L572, and #L575 #L576.
The calculated relative offset is also wrong
The correct approach should be to save the address once after #L569

        // Write opcode
        ZyanU8* address = (ZyanU8*)context->destination + context->bytes_written;
        ZyanUPointer ptr = (ZyanUPointer)address;
        if (opcode == 0xE9)
        {
            *address++ = 0xE9;
        } else
        {
            *address++ = 0x0F;
            *address++ = opcode;
        }

        // Write relative offset
        *(ZyanI32*)(address) = 
            ZyrexCalculateRelativeOffset(length, ptr,
                instruction->absolute_target_address);

[flobernd]

Sorry I am busy with work at the moment and had no time to finish my changes. I just pushed my local progress which definitely does not have the problem you describe. Might have other issues tho .. still work in progress.