Add support for wrapped formatter hooks #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These functions make it easier for the rust code to use the formatter hooks, since there is no more dealing with a `*mut *mut c_char` and all the pointers are already dereferenced, which means that the hook doesn't need any unsafe blocks (usually). This commit also fixes some minor bugs that were undetected until now (i.e. Hook::FuncPrintDecorator had the wrong type and transmuted it which could lead to crashes). The only thing left to do would be to decide whether we actually pass mutable reference to instances of ZydisDecodedInstruction and ZydisDecodedOperand. That would allow setting the user context, for which I don't really see a use case.
th0rex
changed the title
…fields now so we needed to update the casts
…mpile on stable but not on some nightly versions.
|
Merged, ty! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These hooks make it easier to actually print things into a Buffer from rust. There are also some bugfixes in this PR, see the first commit message for more detail.