Skip to content

Commit

Permalink
Don't turn empty target into .
Browse files Browse the repository at this point in the history
  • Loading branch information
zyedidia committed Jul 31, 2023
1 parent 369271f commit 1d0e465
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions knit.go
Original file line number Diff line number Diff line change
Expand Up @@ -268,15 +268,16 @@ func Run(out io.Writer, args []string, flags Flags) (string, error) {
if len(targets) == 0 {
targets = []string{rs.MainTarget()}
}
rootTargets := make([]string, len(targets))
// TODO: don't turn an empty target into '.'
rootTargets := make([]string, 0, len(targets))

if len(targets) == 0 {
return knitpath, errors.New("no targets")
}

for i, t := range targets {
rootTargets[i] = filepath.Base(t)
for _, t := range targets {
if t != "" {
rootTargets = append(rootTargets, filepath.Base(t))
}
}

rs.Add(rules.NewDirectRuleBase([]string{":build"}, targets, nil, rules.AttrSet{
Expand Down

0 comments on commit 1d0e465

Please sign in to comment.