Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

material-tc theme has out of place white scrollbar #1837

Closed
paw-lu opened this issue Aug 18, 2020 · 3 comments · Fixed by #1838
Closed

material-tc theme has out of place white scrollbar #1837

paw-lu opened this issue Aug 18, 2020 · 3 comments · Fixed by #1838

Comments

@paw-lu
Copy link
Contributor

paw-lu commented Aug 18, 2020

Description of the problem or steps to reproduce

material-tc theme has an out of place white scrollbar.

Screen Shot 2020-08-18 at 4 21 55 PM

Have added a PR to fix.

@paw-lu
Copy link
Contributor Author

paw-lu commented Aug 19, 2020

Originally thought this was a theme issue, but I seem unable to change the scrollbar color at all. Is there something I'm missing?

dmaluka added a commit to dmaluka/micro that referenced this issue Aug 20, 2020
@dmaluka
Copy link
Collaborator

dmaluka commented Aug 20, 2020

I see it's not implemented at all. It's pretty easy to implement it though.
I've uploaded #1840 which adds scrollbar color group.

As for the line-number.scrollbar and current-line-number.scroller color groups present in cmc-tc and cmc-16 colorschemes, they were added to the colorschemes by @GeigerCounter in #568 but apparently never implemented. I'm not sure what they were meant for and what's the difference between the two. Judging by the names, perhaps they were meant for some scrollbar embedded in the line ruler at the left edge, not for the regular scrollbar at the right edge.

@paw-lu
Copy link
Contributor Author

paw-lu commented Aug 21, 2020

Thank you so much @dmaluka !

Yeah, I couldn't figure out what scrollbar and scroller were for either 🤷‍♂️. Thanks for the PR! I'll update #1838 once it gets merged!

zyedidia pushed a commit that referenced this issue Aug 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants