Building 1.2.0 from source reports wrong version

[ibrokemypie]

Description of the problem or steps to reproduce

Using this link, micro identifies as 1.1.5-dev.197 rather than 1.2.0
https://github.com/zyedidia/micro/releases/download/v1.2.0/micro-1.2.0-src.tar.gz

Specifications

You can use micro -version to get the commit hash.

Commit hash:
OS:
Terminal:

[tommyshem]

It gets the version from git tag and when I downloaded the source from link above, I also got 1.1.5-dev.197. When you run git tag there is no v1.2.0 tag in the git repo, so you get dev tag version instead.

[zyedidia]

I have fixed this problem so in the future releases will have the correct tags for their .git directory. The main issue was that the binaries were compiled and zipped before the tag was made.

I still don't really see the appeal of having a micro-version-src.tar.gz file at all. Previously it was useful to get all the dependencies as well, but now all dependencies are provided anyway in the git repo in the form of submodules. So now I don't see the appeal of the source tarball because you can just clone it. Of course, if you don't have git installed that is a problem but then you won't be able to build the version in the first place (because getting the version requires git) and you won't even be able to build micro at all because the go compiler requires git.

Perhaps now the only reason to provide the source tarball is because some package scripts depend on it?

I have also uploaded new source tarballs that contain the correct versions for 1.2.0.

[ibrokemypie]

I know over at void linux it is certainly much preferred to use tarballs than to clone with git, but I agree, especially for go where git already needs to be present, it really shouldnt be necessary to provide the version-src files