Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shellcheck as a new shell linter + runtime.go out of git control #2157

Merged
merged 2 commits into from
Jul 16, 2021
Merged

Shellcheck as a new shell linter + runtime.go out of git control #2157

merged 2 commits into from
Jul 16, 2021

Conversation

alikefia
Copy link
Contributor

No description provided.

@alikefia
Copy link
Contributor Author

Found a custom way (from init.lua)

linter.removeLinter("shfmt")
linter.makeLinter("shellcheck", "shell", "shellcheck", {"-f", "gcc", "%f"}, "%f:%l:%c:.+: %m")

@alikefia
Copy link
Contributor Author

@zyedidia, 2 questions please

  1. do you want to change / add shellcheck linter in default config ?
  2. agree to remove runtime.go from git control ?

@zyedidia
Copy link
Owner

Shellcheck is fine. Let's keep runtime.go for now because it makes it possible to install using go get/go install. I think we can remove it when we switch to using the built-in embed package at some point in the future.

@alikefia
Copy link
Contributor Author

Done ! runtime.go regenerated...

@zyedidia zyedidia merged commit 1a5518e into zyedidia:master Jul 16, 2021
@alikefia alikefia deleted the shellcheck branch July 16, 2021 19:39
@totoroot totoroot mentioned this pull request Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants