Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some fixes #2763

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Some fixes #2763

wants to merge 6 commits into from

Conversation

mjholub
Copy link
Contributor

@mjholub mjholub commented Mar 1, 2023

I have removed some variable shadowing, commented out code and moved some global variables where they are needed. However there is one problem which I don't have the time to debug now, but which causes the program to segfault when it opens a file is this:

pkg/highlight/parser.go:322:7: SA5000: assignment to nil map (staticcheck)
                                                Groups[groupStr] = numGroups
                                                ^
pkg/highlight/parser.go:360:3: SA5000: assignment to nil map (staticcheck)
                Groups[group] = numGroups
                ^
pkg/highlight/parser.go:392:4: SA5000: assignment to nil map (staticcheck)
                        Groups[groupStr] = numGroups

This output was generated by golangci-lint, which can be also integrated into the project. See my setup for one of my project as some opinionated starter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant