Enable syntax highlighting for vue files using <script setup> syntax #2918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeKar
requested changes
Sep 13, 2023
runtime/syntax/vue.yaml
Outdated
Comment on lines
59
to
63
| - default: | ||
| start: "<script[ ]+setup>" | ||
| end: "</script>" | ||
| rules: | ||
| - include: "javascript" |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
runtime/syntax/vue.yaml
Outdated
Comment on lines
65
to
69
| - default: | ||
| start: "<script[ ]+setup[ ]+lang=(\"ts\"|'ts')>" | ||
| end: "</script>" | ||
| rules: | ||
| - include: "typescript" |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
runtime/syntax/vue.yaml
Outdated
Comment on lines
78
to
83
| - default: | ||
| start: "<style[ ]+scoped.*?>" | ||
| end: "</style.*?>" | ||
| limit-group: symbol.tag | ||
| rules: | ||
| - include: "css" |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
Thank you for the feedback. I attempted to address your suggestions in my latest commit. I'm also simplifying the |
JoeKar
reviewed
Sep 15, 2023
runtime/syntax/vue.yaml
Outdated
|
|
||
|
|
||
There was a problem hiding this comment.
You added unintended white spaces?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the syntax highlighting issue raised in #2381