Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install the snap with make #747

Merged
merged 3 commits into from
Jul 26, 2017
Merged

install the snap with make #747

merged 3 commits into from
Jul 26, 2017

Conversation

come-maiz
Copy link
Contributor

No description provided.

@come-maiz
Copy link
Contributor Author

One error remaining:

cmd/micro/bindings.go:240: undefined: tcell.KeyCtrlPgUp
cmd/micro/bindings.go:241: undefined: tcell.KeyCtrlPgDn

@zyedidia
Copy link
Owner

How are you downloading the git repository? Micro should come with all the dependencies as submodules. But that does mean that you need to run git submodule init and git submodule update (actually make install will run git submodule update for you). I noticed that you run go get -d ./cmd/micro in the snap instructions. This shouldn't be necessary because micro should come with the dependencies.

My guess would be that the submodules are not being initialized, so go get is fetching all the dependencies, which fetches the incorrect version of tcell (micro shouldn't be using the master version which is what go get fetches), giving this error.

I have just updated the makefile to run git submodule update --init which should initialize the submodules if they are not already. So that should fix the problem now.

Thanks for all your help getting this to work!

@come-maiz
Copy link
Contributor Author

@zyedidia the idea is not to download the code again during the build, because you already have a local clone of the repo.
I can add source-type: git, and that will run the update. And let me try without the get.

@come-maiz
Copy link
Contributor Author

@zyedidia ready!

@zyedidia zyedidia merged commit fad95c0 into zyedidia:master Jul 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants