Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat fix table 28 #113

Merged
merged 17 commits into from
Mar 31, 2023
Merged

Feat fix table 28 #113

merged 17 commits into from
Mar 31, 2023

Conversation

ZurabDev
Copy link
Contributor

@ZurabDev ZurabDev commented Mar 29, 2023

Features

  • feat(doc/input-date-range): add example with presets list 🎨
  • feat(doc/calendar-range): add example with presets list 🎨
  • feat(doc/table): add exmple with stick to left, to right, to bottom side 🎨 104
  • feat(doc/sticky): add doc for new directive prizmStick 🎨 104
  • feat(component/sticky): add new directive prizmStick for sticky to any side with dynamic calculations 🎨 104
  • feat(components/switcher): add disabled and add support template icon 117 🎨

Bug Fixes

  • fix(components/table): pass correct context to row 110
  • fix(componets/input-date-period): fix export 107
  • fix(components/dialog): fix error with more then context size 108
  • fix(components/confirm-dialog): fix error with more then context size 108
  • fix(components/sidebar): error with double height set 101
  • feat(components/select): null content does not show 116
  • fix(components/toast): toasts overlap each other 118
  • fix(components/sidebar): can not pass footer template 94
  • fix(components/select): fix full width 120
  • fix(comopnents/select): validator required does not work 119

alexhawkins94
alexhawkins94 previously approved these changes Mar 30, 2023
@github-actions
Copy link

github-actions bot commented Mar 30, 2023

Visit the preview URL for this PR (updated for commit 29e5a85):

https://prizmui--pr113-feat-fix-table-28-zaytpaot.web.app

(expires Wed, 05 Apr 2023 14:17:01 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2a7a6ffb1b98d3f03fb1ef68a470776e775db980

Copy link

@alexhawkins94 alexhawkins94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

При изменении масштаба браузера sticky колонки и ряды отображаются некорректно - будто в отрыве от остальной таблицы

chrome_RaPsePwcox

chrome_QoqXityOx2

@alexhawkins94
Copy link

В live demo компонента switcher не требуется ли вынести свойство disabled?

@alexhawkins94
Copy link

Двойная граница в примере preset list компонента inputDateRange
chrome_272YYbpPUl

@alexhawkins94
Copy link

Не применяется footer для компонента sidebar
chrome_2TSu6xzShy

@alexhawkins94
Copy link

alexhawkins94 commented Mar 31, 2023

В пример со sticky колонками в табличке я бы добавил еще горизонтальный скролл - чтоб наглядно было видно, что колонки sticky без изменения размера окна бразуера/масштаба

@ZurabDev ZurabDev self-assigned this Mar 31, 2023
@ZurabDev ZurabDev merged commit cd54725 into main Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants