Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components/tab): add correct icon name to registry for right arrow #1860 #1865

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

ickisIckis
Copy link
Collaborator

fix(components/tab): add correct icon name to registry for right arrow #1860

Библиотека

  • @prizm-ui/components
  • @prizm-ui/install
  • @prizm-ui/icons
  • @prizm-ui/theme

Компонент

Tabs

resolved #1860

  • Ссылка на issue(если есть)

Изменения

  • Имеются BREAKING CHANGES
  • Изменения документации
  • Добавление фичи
  • Исправление бага

Checklist:

  • После фичи обновил документацию
  • Сделал код чище чем был до этого
  • Тесты и линтер на рабочей машине успешно выполнились

Следует обратить внимание на ревью

Иконки в табах, проверить, что ничего не потерялось

Release Notes

Исправили имя для иконки прокрутки вправо

@ickisIckis ickisIckis added this to the 4.4.0 milestone Jul 10, 2024
@ickisIckis ickisIckis requested a review from ZurabDev July 10, 2024 13:06
Copy link

Visit the preview URL for this PR (updated for commit c6e05a8):

https://prizm-v4--pr1865-fix-tabs-icon-right-1xnhxf7g.web.app

(expires Mon, 15 Jul 2024 13:12:20 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 7c62ed8dbabf5e2d6b2084ca9e107cc206d30dbd

Copy link
Contributor

@ZurabDev ZurabDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ickisIckis ickisIckis added the state:ready ready for release (pass tested) label Jul 12, 2024
@ZurabDev ZurabDev merged commit 3785f69 into main Jul 17, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
availability:tested state:ready ready for release (pass tested) version:4
Projects
None yet
3 participants