Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update _detail.scss #51

Merged
merged 5 commits into from
Oct 22, 2020
Merged

Update _detail.scss #51

merged 5 commits into from
Oct 22, 2020

Conversation

carolineignr
Copy link

Atualiza o arquivo _detail.scss com o elemento modal-detail.

@@ -0,0 +1,16 @@
.modal-show-detail {
.product-detail {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acha que é realmente necessário o product-detail aqui?
Por exemplo.. se eu pude-se usar esse modal-show-detail pra mostrar detalhes de uma store, ou de uma oferta? o product parece ta restringindo bastante. Só se a ideia é ser especifico só para products. Mas acho difícil a gente já saber agora.

@@ -723,3 +723,20 @@
}
}
}

.modal-detail {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ainda precisa ter aqui no detail?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

opa, esqueci de apagar

@carolineignr carolineignr merged commit 7f2f3b6 into master Oct 22, 2020
@CarlosMouraJR CarlosMouraJR deleted the modal-product-detail branch May 19, 2021 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants