Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fallback for plain elm #294 #290 #299

Merged
merged 2 commits into from
May 19, 2023
Merged

Add fallback for plain elm #294 #290 #299

merged 2 commits into from
May 19, 2023

Conversation

mdeweerd
Copy link
Contributor

To be validated by users.

@PulpCattel PulpCattel mentioned this pull request May 18, 2023
@mdeweerd
Copy link
Contributor Author

@imartinez I tested this with samples from https://github.com/mikel/mail/tree/master/spec/fixtures/emails/plain_emails .

The code also demonstrates how wrap an existing loader so that the existing LOADER_MAPPING dict can be maintained

Copy link
Collaborator

@imartinez imartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking really good. I think we should move custom loaders to their own files, but I think it is a good idea to keep this first one in ingest.py for the moment so people can see how to create custom loaders.

@imartinez imartinez merged commit 22945bc into zylon-ai:main May 19, 2023
@mdeweerd
Copy link
Contributor Author

I think we should move custom loaders to their own files

Certainly, but after adding #120 which moves the scripts to their own directory ;-), and maybe just one file such as "loaders.py".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants