reversed delay effect

[friedolino78]

not yet synced to bpm. but the audio part seems to work

[JohannesLorenz]

The caption is a bit misleading? While this is a reverter which re-uses the Comb Filter code, it is not a comb filter? A filter would usually have a frequency and a resonance.

[friedolino78]

While this is a reverter which re-uses the Comb Filter code, it is not a comb filter? A filter would usually have a frequency and a resonance.

that's right. this has only a frequency. since it cannot oscillate a resonance makes no sense. question is if the REV filter type has any use or should be removed.

[fundamental]

I'd be in favor of refactoring the rev mode out of the comb filter code since I'd argue it's its own effect. At least my general expectation is that you'd only want this reverse mode as an effect and not within individual filters in add/pad/sub.

[friedolino78]

I'd be in favor of refactoring the rev mode out of the comb filter code since I'd argue it's its own effect. At least my general expectation is that you'd only want this reverse mode as an effect and not within individual filters in add/pad/sub.

ok. removal it will be.

[friedolino78]

ready for review again.

[friedolino78]

unfortunatelly the sound is broken now. please help

[fundamental]

Here's a test that should help replicate some of the valgrind issues
quick-random-test.txt

[fundamental]

I don't know if it produces the right audio, but it looks like the valgrind issues are by and large resolved via:

diff --git a/src/DSP/Reverter.cpp b/src/DSP/Reverter.cpp
index fcadd8f6..9f3061d3 100644
--- a/src/DSP/Reverter.cpp
+++ b/src/DSP/Reverter.cpp
@@ -14,7 +14,19 @@ namespace zyn{
 
 Reverter::Reverter(Allocator *alloc, float delay,
     unsigned int srate, int bufsize, float tRef)
-    :gain(1.0f), samplerate(srate), buffersize(bufsize), buffercounter(0), fading_samples((int)srate/25), memory(*alloc)
+    :input(nullptr),
+    gain(1.0f),
+    delay(0.0f),
+    phase(0.0f),
+    buffercounter(0),
+    reverse_offset(0.0f),
+    phase_offset(0.0f),
+    reverse_pos_hist(0.0f),
+    fading_samples((int)srate/25),
+    fade_counter(0),
+    memory(*alloc),
+    samplerate(srate),
+    buffersize(bufsize)
 {
     
     // (mem_size-1-buffersize)-(maxdelay-1)-2*fading_samples-maxphase > 0