Icon() expected Fl_RGB_Image and received Pixmap. FLTK icons work now. #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Probably the cause of #zynaddsubfx/zyn-fusion-build#30 |
fundamental
reviewed
Feb 18, 2020
|
I'm going to review it further, but it may be true that the XCreatePixmapFromData call was the only function call to X11/xpm.H and it can be removed from the codebase. ...it was easier to check than I thought. xpm.h is not used anywhere else in MasterUI.fl as piece I changed is the only PLUGINVERSION && HAS_X11 conditional. I will remove its class declaration. |
|
Thanks for the update 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.