Pianoteq 7.2.0 PRO appears as STANDARD in the Zynthian UI #351

bigmalletman · 2021-03-11T00:04:47Z

Describe the bug
I am a PRO user. I appear as a PRO user in the Pianoteq UI, but Zynthian is reporting me as STANDARD. There does not appear to be a separate binary for PRO, or PRO reports itself differently now.

/zynthian/zynthian-sw/pianoteq6/arm-32bit/Pianoteq\ 7\ PRO
does not exist, it is just
/zynthian/zynthian-sw/pianoteq6/arm-32bit/Pianoteq\ 7

root@zetes:/zynthian/zynthian-sw/pianoteq6# ./pianoteq --version
Pianoteq version 7.2.0/20210212 – http://www.pianoteq.com/pianoteq
Copyright © 2021 Modartt.

in that Pianoteq72.prefs file…
VALUE name=“LKey” val="# Pianoteq key file (v7) # Product: Pianoteq 7 PRO # Licensed to: Daniel Wells # Computer: zetes # Date: Wed Mar 10 21:36:07 2021 …

root@zetes:/zynthian/zynthian-sw/pianoteq6# echo $PIANOTEQ_PRODUCT
STANDARD
root@zetes:/zynthian/zynthian-sw/pianoteq6# echo $PIANOTEQ_VERSION
7.2.0
root@zetes:/zynthian/zynthian-sw/pianoteq6# echo $PIANOTEQ_TRIAL
0

To Reproduce
I own Pianoteq PRO 7.2.0. I just downloaded it from https://www.modartt.com/. It is possible how Pianoteq reports STANDARD vs PRO has changed. There is not separate binary as far as I can tell.

Expected behavior
Although I don't think I'm missing any features, Zynthian should appear as PRO, not STANDARD

Screenshots
https://discourse.zynthian.org/uploads/default/optimized/2X/5/5d41168448da5329bc12490a1d3a10cbf2378784_2_435x500.png
https://discourse.zynthian.org/uploads/default/optimized/2X/2/2621bd73c6b9ae3825f73933fc731c895f826a61_2_690x150.png
https://discourse.zynthian.org/uploads/default/original/2X/a/a3305060b37ec97e421001a3abf29a1024c337e5.png

Additional context
Discourse for this issue: https://discourse.zynthian.org/t/zynthian-doesnt-realize-i-upgraded-to-pianoteq-pro-and-have-new-instruments/

jofemodo · 2021-07-05T17:17:26Z

It seems like Moddart changed the ID string format when running " ./pianoteq --version". Or perhaps they are using the same binary file for STANDARD and PRO. For solving this we should look for the version on the prefs file instead of using "pianoteq --version".

mheidt · 2021-10-28T14:43:40Z

@bigmalletman
Could you please test the changes using testing branch for zynthian-ui?
You need to install the binary again to make it happen.

bigmalletman · 2021-10-28T16:46:30Z

I applied the change to zynthian-ui/zyngine/zynthian_engine_pianoteq.py. However, it now presents the Activation text field again. I can't remember if this is normal or not. Pianoteq itself still seems to be operating normally.

mheidt · 2021-10-28T18:26:34Z

That looks good, doesn't it?
The next time you upload a binary, the activation key shouldn't be empty. Could you try that? (you have entered it already, I hope)
For the zynthian it's the first time, that you uploaded a Pro. Your former key might be in the the environment file of the standard version. But I am guessing here.

bigmalletman · 2021-10-28T19:24:12Z

After applying the patch to zynthian_engine_pianoteq.py and re-uploading the binary, I see three files in ~/.config/Modartt.
Pianoteq74.prefs 'Pianoteq74 PRO.prefs' Pianoteq74_tempb70d0430.prefs
Pianoteq74.prefs was correct with my key, but Pianoteq74\ PRO.prefs is wrong.
I tried renaming Pianoteq74.prefs to Pianoteq74\ PRO.prefs
reboot
Once I did this, the web UI looks correct again, but now Pianoteq does not run anymore. No sounds when I press the keyboard. A new Pianoteq74.prefs was also recreated that is wrong.

I'm not sure why it is appending "PRO" to filenames and still attempting to read from both. The pianoteq executable stopped appending "PRO" to the file in version 7.
To be clear, Pianoteq 7 has ONE executable. There are not separate uploads for standard and pro. So I think the current setup cannot figure out which prefs file to use, maybe?

bigmalletman · 2021-10-28T20:03:24Z

Okay... i fixed everything on my setup by changing at zyngine/zynthian_engine_pianoteq.py:228.

if PIANOTEQ_PRODUCT == "STANDARD":
	PIANOTEQ_CONFIG_FILENAME = "{}.prefs".format(PIANOTEQ_NAME)
else:
	PIANOTEQ_CONFIG_FILENAME = "{} {}.prefs".format(PIANOTEQ_NAME, PIANOTEQ_PRODUCT)

to just

PIANOTEQ_CONFIG_FILENAME = "{}.prefs".format(PIANOTEQ_NAME)

I am a C/C++/Java programmer, not a Python programmer. Trying to trace this is interesting.

I now only have ONE Pianoteq74.prefs in ~/.config/Modartt
and the webUI looks right.

I realize I probably should have included if PIANOTEQ_VERSION[0] > 6 somewhere to ensure this works with older versions of pianoteq where "PRO" would be appended to the prefs file...

bigmalletman · 2021-10-28T20:34:45Z

if PIANOTEQ_VERSION[0] > 6:
        PIANOTEQ_CONFIG_FILENAME = "{}.prefs".format(PIANOTEQ_NAME)
else:
        if PIANOTEQ_PRODUCT == "STANDARD":
                PIANOTEQ_CONFIG_FILENAME = "{}.prefs".format(PIANOTEQ_NAME)
        else:
                PIANOTEQ_CONFIG_FILENAME = "{} {}.prefs".format(PIANOTEQ_NAME, PIANOTEQ_PRODUCT)

I guess?

mheidt · 2021-10-28T20:52:07Z

So you are telling me, that if you deleted all pref files, installed from scratch and applied the product key, Pianoteq would not start with activation because it requests the pref file without the PRO?
Mine is working fine with:
Pianoteq74 STAGE.prefs

bigmalletman · 2021-10-28T20:57:50Z

I did delete all my pref files, but I simply cannot completely redo my Pianoteq from scratch with live performances so near in the future.
It appears that Pianoteq is using Pianoteq74.prefs, but Zynthian is trying to use Pianoteq74 PRO.prefs. If I do not modify line 228, my setup is broken.
It is reasonable that it would not use Pianoteq74 PRO.prefs. You had to add code to identify STANDARD vs PRO to begin with.

mheidt · 2021-10-29T11:47:31Z

I don't know why it was done. But I wouldn't change it. Maybe to have the option to keep Trial and other versions in parallel.
Could you test it again after your performance without the goal to keep the old file?
I wonder, why you just can't rename the file though. (and delete the existing 74 files)

bigmalletman · 2021-10-29T16:02:38Z

@mheidt i have some free time today, so I'll make backups and test my theories and get back to you.

bigmalletman · 2021-10-29T16:41:28Z

Here's what I did...
Removed ~/.config/Pianoteq74.prefs
Removed /zynthian/zynthian-sw/pianoteq6
Reverted my code changes in /zynthian/zynthian-ui/zyngine/zynthian_engine_pianoteq.py near 228
Reboot
Uploaded pianoteq_linux_v742.7z at http://url/sw-pianoteq
Reboot
Reactived at http://url/sw-pianoteq
Activation does not appear correctly... as I have PRO, not STANDARD.

Appears correctly in xterm.

root@zetes:/zynthian/zynthian-sw/pianoteq6/arm-32bit# ls
 extra	'Pianoteq 7'  'Pianoteq 7.lv2'	'Pianoteq 7.so'

root@zetes:/zynthian/zynthian-sw/pianoteq6# ./pianoteq --version
Pianoteq version 7.4.2/20211011 -- http://www.pianoteq.com/pianoteq
Copyright (c) 2021 Modartt.

root@zetes:~/.config/Modartt# ls
 Pianoteq74.prefs  'Pianoteq74 PRO.prefs'

Checking the prefs files...
Pianoteq74.prefs contains...

...
VALUE name="LKey" val="# Pianoteq key file (v7)
# Product: Pianoteq 7 PRO
# Licensed to: Daniel
...

Pianoteq74\ PRO.prefs contains... very little...

bigmalletman · 2021-10-29T16:57:58Z

Upon a totally fresh reinstall of Pianoteq 7 and new prefs and activation. This change did not seem to fix.

mheidt · 2021-10-29T20:40:56Z

Ah damn, @jofemodo
the LKEY only exists after activation or first start...chicken/egg problem.

mheidt · 2021-10-29T20:45:46Z

@dcoredump
Do you remember, why you coded the product (PRO, STAGE) into the pref file name?

dcoredump · 2021-10-30T10:18:32Z

Unfortunately not. That was so long ago now that I can't remember. I havn't touchec the code since then either. But actually it should not be so problematic to change this.

mheidt · 2021-10-30T10:23:06Z

Ok.
@bigmalletman
Could you test the code with just the line
PIANOTEQ_CONFIG_FILENAME = "{}.prefs".format(PIANOTEQ_NAME)
No "if" against version 6.
Do you want to do a PR afterwards or should I do it?

mheidt · 2021-10-31T15:11:13Z

@bigmalletman
It's not going to be that easy. I tested it with my binary (STAGE). The issue seems to be, that pianoteq is creating the prefs file before the activation with a STAGE in the name.
So...when you deleted all 74 prefs and uploaded a new binary. What is the name of the prefs in your case? without PRO? Wonder how it looked like with a STANDARD version.

Please try this:

if PIANOTEQ_PRODUCT != "STAGE":
	PIANOTEQ_CONFIG_FILENAME = "{}.prefs".format(PIANOTEQ_NAME)
else:
	PIANOTEQ_CONFIG_FILENAME = "{} {}.prefs".format(PIANOTEQ_NAME, PIANOTEQ_PRODUCT)

bigmalletman · 2021-10-31T15:25:56Z

I don't entirely understand the question. The binary is the same between Standard and Pro. Your activation determines which features you get, not the binary. My webUI is currently showing STANDARD, even though I have PRO activated, and I'm not sure how to get it to show PRO again like before.
To me, it seems reasonable for the workflow to check the version each time the sw-pianoteq page is visited.
Alternatively, remove the "Product" information altogether. Since Zynthian does not directly use any of the additional features of higher products, it might be reasonable to only present to the user that Pianoteq is activated.

mheidt · 2021-11-01T11:50:38Z

What I learned the last time is, that it's not on us to decide how to name the .prefs file. During the first run Pianoteq itself creates the file. We just have to adapt.
Holger knew during his first implementation, that for STANDARD, the prefs file was generated without the product info (STAGE or PRO) and for STAGE it was shown. We could only test with STAGE and the Trial version (STANDARD), because we didn't know any person having a PRO license. That's why he assumed (and I would have as well), that PRO should show as well.
Now we know, that PRO is not showing. That's why I changed the code like in my last statement.
Could you test that code?

bigmalletman · 2021-11-01T13:38:59Z

I feel like I must not be communicating well. Here is the sentence I would like to highlight:

My webUI is currently showing STANDARD, even though I have PRO activated, and I'm not sure how to get it to show PRO again like before.

Here are the relevant code segments:

After I uploaded my binary, the sw-pianoteq page displayed at "STANDARD". When I activated the product, the page did not change from "STANDARD" to "PRO", even though my LKey contains "pro".

VALUE name="LKey" val="# Pianoteq key file (v7)
# Product: Pianoteq 7 PRO
# Licensed to: Daniel Wells
# Computer: zetes
# Date: Fri Oct 29 17:08:06 2021

Please note that the val contains control code "10" for "Line feed", but github is displaying the above as new lines.

I cannot seem to get the product displayed in the webUI to change from "STANDARD" to "PRO".
So to test, I added this line...

However, the webUI still does not change from "STANDARD" to "CHEESE".
When does the get_pianoteq_binary_info() function actually get called?? Since the product type is determined by the activation, not the upload, it needs to be called more often.

mheidt · 2021-11-01T18:05:24Z

OK,
Please try adding those two lines in the webconf:

		else:
			self.pianoteq_autoconfig()

bigmalletman · 2021-11-04T18:14:57Z

Okay... everything seems to be working here.

Sorry for the delay. I'm in two bands and a musical theatre show right now.

* zynthian/zynthian-issue-tracking#547 repository page / PEP8 reformating * zynthian/zynthian-issue-tracking#547 repository page modifications * zynthian/zynthian-ui#351 Pianoteq PRO fixes Co-authored-by: Markus Heidt <markus.heidt@heidt-tech.com>

mheidt · 2021-11-04T19:00:36Z

Great.
Once the PR is merged into testing, you could test it a final time before we close this issue.
Thanks,
Markus

#351 Pianoteq PRO fixes

bigmalletman · 2022-04-09T14:45:33Z

What is the status of this one? Apparently my zynthian has had a lot of updates since last time I used. Now Pianoteq75 PRO.prefs is back.
It doesn't look like any of the changes here never made it to production?

jofemodo · 2022-04-15T18:13:35Z

Not yet. We hope to release a new stable very soon, including all the latest changes.
For the future, we will change the way big changes are developed and tested. We have learned a few lessons in the current development cycle.

riban-bw · 2022-11-07T16:36:01Z

Stable release fixed this.

bigmalletman changed the title ~~Pianoteq 7.2.0 PRO appears at STANDARD in the Zynthian UI~~ Pianoteq 7.2.0 PRO appears as STANDARD in the Zynthian UI Mar 11, 2021

jofemodo self-assigned this Mar 11, 2021

jofemodo transferred this issue from zynthian/zynthian-issue-tracking Mar 11, 2021

jofemodo added the bug Something isn't working label Mar 11, 2021

jofemodo added this to New in Zynthian Tracker via automation Mar 11, 2021

jofemodo moved this from New to Analyzing in Zynthian Tracker Mar 11, 2021

mheidt pushed a commit that referenced this issue Oct 25, 2021

#351 Pianoteq: reading prefs file for product value

aa9dae1

mheidt mentioned this issue Oct 25, 2021

Pianoteq fixes #407

Merged

mheidt pushed a commit to zynthian/zynthian-webconf that referenced this issue Nov 4, 2021

zynthian/zynthian-ui#351 Pianoteq PRO fixes

0cbdd93

mheidt pushed a commit that referenced this issue Nov 4, 2021

#351 Pianoteq PRO fixes

d43e376

mheidt mentioned this issue Nov 4, 2021

Fixing label issues with Pianoteq PRO zynthian/zynthian-webconf#171

Merged

jofemodo added a commit that referenced this issue Dec 13, 2021

Merge pull request #411 from zynthian/zui351

c66778e

#351 Pianoteq PRO fixes

jofemodo pushed a commit that referenced this issue Jul 25, 2022

#351 Pianoteq: reading prefs file for product value

5ab9660

jofemodo pushed a commit that referenced this issue Jul 25, 2022

#351 Pianoteq PRO fixes

30294c8

riban-bw closed this as completed Nov 7, 2022

Zynthian Tracker automation moved this from Blocked to Testing Nov 7, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pianoteq 7.2.0 PRO appears as STANDARD in the Zynthian UI #351

Pianoteq 7.2.0 PRO appears as STANDARD in the Zynthian UI #351

bigmalletman commented Mar 11, 2021

jofemodo commented Jul 5, 2021

mheidt commented Oct 28, 2021

bigmalletman commented Oct 28, 2021 •

edited

mheidt commented Oct 28, 2021

bigmalletman commented Oct 28, 2021 •

edited

bigmalletman commented Oct 28, 2021 •

edited

bigmalletman commented Oct 28, 2021 •

edited

mheidt commented Oct 28, 2021 •

edited

bigmalletman commented Oct 28, 2021 •

edited

mheidt commented Oct 29, 2021

bigmalletman commented Oct 29, 2021

bigmalletman commented Oct 29, 2021 •

edited

bigmalletman commented Oct 29, 2021

mheidt commented Oct 29, 2021 •

edited

mheidt commented Oct 29, 2021

dcoredump commented Oct 30, 2021

mheidt commented Oct 30, 2021

mheidt commented Oct 31, 2021 •

edited

bigmalletman commented Oct 31, 2021

mheidt commented Nov 1, 2021

bigmalletman commented Nov 1, 2021 •

edited

mheidt commented Nov 1, 2021

bigmalletman commented Nov 4, 2021 •

edited

mheidt commented Nov 4, 2021

bigmalletman commented Apr 9, 2022 •

edited

jofemodo commented Apr 15, 2022

riban-bw commented Nov 7, 2022

Pianoteq 7.2.0 PRO appears as STANDARD in the Zynthian UI #351

Pianoteq 7.2.0 PRO appears as STANDARD in the Zynthian UI #351

Comments

bigmalletman commented Mar 11, 2021

jofemodo commented Jul 5, 2021

mheidt commented Oct 28, 2021

bigmalletman commented Oct 28, 2021 • edited

mheidt commented Oct 28, 2021

bigmalletman commented Oct 28, 2021 • edited

bigmalletman commented Oct 28, 2021 • edited

bigmalletman commented Oct 28, 2021 • edited

mheidt commented Oct 28, 2021 • edited

bigmalletman commented Oct 28, 2021 • edited

mheidt commented Oct 29, 2021

bigmalletman commented Oct 29, 2021

bigmalletman commented Oct 29, 2021 • edited

bigmalletman commented Oct 29, 2021

mheidt commented Oct 29, 2021 • edited

mheidt commented Oct 29, 2021

dcoredump commented Oct 30, 2021

mheidt commented Oct 30, 2021

mheidt commented Oct 31, 2021 • edited

bigmalletman commented Oct 31, 2021

mheidt commented Nov 1, 2021

bigmalletman commented Nov 1, 2021 • edited

mheidt commented Nov 1, 2021

bigmalletman commented Nov 4, 2021 • edited

mheidt commented Nov 4, 2021

bigmalletman commented Apr 9, 2022 • edited

jofemodo commented Apr 15, 2022

riban-bw commented Nov 7, 2022

bigmalletman commented Oct 28, 2021 •

edited

bigmalletman commented Oct 28, 2021 •

edited

bigmalletman commented Oct 28, 2021 •

edited

bigmalletman commented Oct 28, 2021 •

edited

mheidt commented Oct 28, 2021 •

edited

bigmalletman commented Oct 28, 2021 •

edited

bigmalletman commented Oct 29, 2021 •

edited

mheidt commented Oct 29, 2021 •

edited

mheidt commented Oct 31, 2021 •

edited

bigmalletman commented Nov 1, 2021 •

edited

bigmalletman commented Nov 4, 2021 •

edited

bigmalletman commented Apr 9, 2022 •

edited