Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pianoteq and C.Bechstein #159

Closed
mheidt opened this issue Oct 13, 2019 · 6 comments
Closed

Pianoteq and C.Bechstein #159

mheidt opened this issue Oct 13, 2019 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@mheidt
Copy link
Contributor

mheidt commented Oct 13, 2019

I bought the BechsteinDG:A licence and found a nice bug.

The issue is, that the presets of the old C. Bechstein and the new C. Bechstein DG are in the same tag.

"C. Bechstein": [["C. Bechstein DG Prelude", null, "DG Prelude", null],
....
["C. Bechstein DG Broken", null, "DG Broken", null], ["C. Bechstein", null, "", null], ["C. Bechstein Close Mic", null, "Close Mic", null], ...

The problem that we have is, that the C. Bechstein only appears once and in the demo section.
If I select a C.Bechstein DG instrument, I can play all keys and if I chose a NON DG bank, I have the demo behaviour. Like expected.

Personally I think, this is a Pianoteq issue and they should manage their preset list and divide them. But I think, that they won't.

I am not quite sure, how we should tackle it.

Changing bank_list_v6_4 = [
('BechsteinDG', 0, 'BechsteinDG', '_', 'BechsteinDG:A')
]

to

bank_list_v6_4 = [
('C. Bechstein', 0, 'BechsteinDG', '_', 'BechsteinDG:A', 'C. Bechstein DG')
]

where the last value is a filter of the instruments. And we should use that last parameter instead of the first as bank name?

Do you agree?

@mheidt mheidt added the bug Something isn't working label Oct 13, 2019
@mheidt
Copy link
Contributor Author

mheidt commented Oct 13, 2019

Or what about bank[2]?
Should we use that one to filter the instruments?

@mheidt
Copy link
Contributor Author

mheidt commented Oct 13, 2019

Ok, the solution is rather in
logging.info("Caching Internal Presets ...")
#Get internal presets from Pianoteq ...
try:
pianoteq=subprocess.Popen([PIANOTEQ_BINARY, "--list-presets"],stdout=subprocess.PIPE)
for line in pianoteq.stdout:
l=line.rstrip().decode("utf-8")
logging.debug("PRESET => {}".format(l))

@mheidt
Copy link
Contributor Author

mheidt commented Oct 13, 2019

If I change the bank definition to
bank_list_v6_4 = [
('C. Bechstein DG', 0, 'C. Bechstein DG', '_', 'BechsteinDG:A')
]

This bank has the correct instrument selection.
But C. Bechstein has all :)

Solution is close...

@mheidt
Copy link
Contributor Author

mheidt commented Oct 13, 2019

PushRequest....

@mheidt
Copy link
Contributor Author

mheidt commented Oct 13, 2019

Maybe the banklist needs to be sorted by length first, so that the longer bank names are considered first?

@jofemodo jofemodo added this to Work in Progress in Zynthian Tracker Oct 13, 2019
@jofemodo
Copy link
Member

Merged! It should solve the problem by now ... although as you say, Pianoteq should add a column with the "Instrument" when listing presets ... I will try to convince them ;-)

Zynthian Tracker automation moved this from Work in Progress to Testing Oct 14, 2019
@jofemodo jofemodo moved this from Testing to Done in Zynthian Tracker Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants