Cache MAC address to speed up uuid1/0 #45
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #40.
Getting the MAC address (through
:inet.getifaddrs/0
) is slow, resulting in theuuid1/0
function being around 100x slower than the other UUID functions. With this commit we're starting up a GenServer that caches the MAC address in:persistent_term
if available or ETS otherwise. This GenServer refreshes the MAC address every 10 seconds.Benchmark before:
Benchmark after:
cc @zyro, sorry it took a few months to get to this 😄