Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compiling fails for the Arduino Zero and entire Arduino MKR series boards #42

Closed
1 task done
ZZ-Cat opened this issue Oct 17, 2023 · 0 comments · Fixed by #44
Closed
1 task done

Compiling fails for the Arduino Zero and entire Arduino MKR series boards #42

ZZ-Cat opened this issue Oct 17, 2023 · 0 comments · Fixed by #44
Assignees
@ZZ-Cat
Labels
Arduino IDE ♾️ This is specific to the Arduino IDE 🚨 Blocks Release 🚨 No release is to be made, until this is resolved. 🐞 Bug 🐞 OH DEAR!!! You seem to have spotted a bug! Compiler 💻 This happens during compiling/building/verifying PlatformIO 👽 This is specific to PlatformIO. ↩️ Regression ↩️ A recursive bug that has survived one or more previous releases.

Comments

@ZZ-Cat
Copy link
Owner

ZZ-Cat commented Oct 17, 2023

Is there an existing issue for this bug?

  • I have searched the issues and there is no existing issue for this bug.

What development environment are you using?

PlatformIO

What board are you using?

Arduino Zero

What part of CRSF for Arduino is this bug related to?

Build/Compile/Upload

Current behaviour

While I was conducting a compile test across all of the supported development boards in the Compatibility Table, I noticed that compiling firmware fails for the following development boards:

  • MKR Fox 1200
  • MKR GSM 1400
  • MKR NB 1500
  • MKR Vidor 4000
  • MKR WAN 1300
  • MKR WAN 1310
  • MKR WiFi 1010
  • MKR Zero
  • Zero (Debug Port)
  • Zero (Native USB Port)

As noted in the list above, this issue affects the Arduino Zero and the entire Arduino MKR series of development boards.

Expected behaviour

Compiling for the Arduino Zero and all Arduino MKR series development boards should succeed, as CRSF for Arduino is compatible with them.

Steps to reproduce

  1. Select any one of the boards from the aforementioned list above.
  2. Compile the selected target.
  3. See error.

Additional information

Screenshots: Compiler errors for Arduino Zero. This applies to the entire Arduino MKR series too.
Screenshot 2023-10-18 112847
Screenshot 2023-10-18 112921

Additional: All other boards (Adafruit's Metro, Feather, and QtPy boards; Seeed Xiao; Teensy 3.x and 4.x; and the entire ESP32 line) are unaffected by this issue. It is only isolated to the Arduino Zero and all Arduino MKR boards.
@ZZ-Cat ZZ-Cat added 🐞 Bug 🐞 OH DEAR!!! You seem to have spotted a bug! Pending 📌 This is waiting for me to check it out labels Oct 17, 2023
@ZZ-Cat ZZ-Cat added this to the Version 0.5.0 milestone Oct 17, 2023
@ZZ-Cat ZZ-Cat self-assigned this Oct 17, 2023
@ZZ-Cat ZZ-Cat added ↩️ Regression ↩️ A recursive bug that has survived one or more previous releases. Compiler 💻 This happens during compiling/building/verifying Arduino IDE ♾️ This is specific to the Arduino IDE PlatformIO 👽 This is specific to PlatformIO. labels Oct 17, 2023
@ZZ-Cat ZZ-Cat pinned this issue Oct 18, 2023
@ZZ-Cat ZZ-Cat added 🚨 Blocks Release 🚨 No release is to be made, until this is resolved. ...in progress 🚧 Development on this is in progress and removed Pending 📌 This is waiting for me to check it out labels Oct 18, 2023
ZZ-Cat added a commit that referenced this issue Oct 18, 2023
@ZZ-Cat
build(build/compile/verify): Set default environment in `platformio.i…
2f63d40 
…ni` to Arduino Zero

This is only temporary, while #42 is being fixed
ZZ-Cat added a commit that referenced this issue Oct 18, 2023
@ZZ-Cat
refactor(hal): Inherit from Stream instead of HardwareSerial
a2b40a6 
Inheriting from `HardwareSerial` is the root cause of #42.
@ZZ-Cat ZZ-Cat mentioned this issue Oct 18, 2023
Merged
@ZZ-Cat ZZ-Cat linked a pull request Oct 18, 2023 that will close this issue
fix(hal): Inherit from Stream instead of HardwareSerial across all supported targets #44
Merged
@ZZ-Cat ZZ-Cat unpinned this issue Oct 21, 2023
@ZZ-Cat ZZ-Cat removed the ...in progress 🚧 Development on this is in progress label Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ZZ-Cat ZZ-Cat

Labels
Arduino IDE ♾️ This is specific to the Arduino IDE 🚨 Blocks Release 🚨 No release is to be made, until this is resolved. 🐞 Bug 🐞 OH DEAR!!! You seem to have spotted a bug! Compiler 💻 This happens during compiling/building/verifying PlatformIO 👽 This is specific to PlatformIO. ↩️ Regression ↩️ A recursive bug that has survived one or more previous releases.
Projects
None yet
Milestone
No milestone
1 participant
@ZZ-Cat