add test for passing objects to Document#set

zzen · May 19, 2011 · c243d10 · c243d10
1 parent 2d33955
commit c243d10
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 1 deletion.
diff --git a/lib/mongoose/document.js b/lib/mongoose/document.js
@@ -203,6 +203,10 @@ Document.prototype.set = function (path, val, type) {
       ? val + '.'
       : '';
 
+    if (path instanceof Document) {
+      path = path.doc;
+    }
+
     var keys = Object.keys(path);
     var i = keys.length;
     var key;

diff --git a/lib/mongoose/schema/documentarray.js b/lib/mongoose/schema/documentarray.js
@@ -92,7 +92,7 @@ DocumentArray.prototype.cast = function (value, doc) {
     for (var i = 0, l = value.length; i < l; i++)
       if (!(value[i] instanceof Subdocument)){
         var doc = new this.caster(null, value);
-        value[i] = doc.init(value[i]);
+        value[i] = doc.init(value[i].doc || value[i]);
       }
 
     return value;

diff --git a/test/types.document.test.js b/test/types.document.test.js
@@ -60,6 +60,13 @@ module.exports = {
       a.save(function(err){
         should.strictEqual(err, null);
       });
+    },
+
+    'objects can be passed to #set': function () {
+      var a = new Subdocument();
+      a.set({ test: 'paradiddle', work: 'good flam'});
+      a.test.should.eql('paradiddle');
+      a.work.should.eql('good flam');
     }
 
 };