Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stops working after waking up from suspend #2

Open
BillyDM opened this issue Apr 26, 2021 · 9 comments
Open

Stops working after waking up from suspend #2

BillyDM opened this issue Apr 26, 2021 · 9 comments
Labels
bug Something isn't working

Comments

@BillyDM
Copy link

BillyDM commented Apr 26, 2021

After waking up my computer from suspend, the amdgpu-fan service seems to stop working (the fans are spinning noticeably louder).

If I run:

sudo systemctl stop amdgpu-fan
sudo systemctl start amdgpu-fan

Then it works again. I didn't have this issue when the aur package still used the chestm007 repo. I wonder if changing WantedBy=default.target to WantedBy=sysinit.target in the service file might be causing the issue?

@BillyDM
Copy link
Author

BillyDM commented Apr 26, 2021

I tried manually setting it to WantedBy=default.target and disabling and re-enabling the service, but that didn't fix it.

@BillyDM
Copy link
Author

BillyDM commented Apr 26, 2021

Oh, I see now that you made this commit, so the issue probably lies there:

chestm007@82649eb

For reference, this is the fan curve I made in etc/amdgpu-fan.yml:

speed_matrix:  # -[temp(*C), speed(0-100%)]
- [0, 30]
- [70, 30]
- [75, 40]
- [80, 50]
- [85, 75]
- [90, 100]

@igo95862
Copy link

igo95862 commented May 5, 2021

FYI there is a bug with Navi where fan speed fails to be red: https://gitlab.freedesktop.org/drm/amd/-/issues/1164

I would rather remove dependency on fan speed. Make the temperature drop be calculated by caching last temperature that the fan speed was set at and that last fan speed. Always write fan speed. (there is a giant performance bump in only opening sysfs files once)

@zzkW35 zzkW35 added the bug Something isn't working label May 6, 2021
@zzkW35
Copy link
Owner

zzkW35 commented May 6, 2021

Hi,
first of all thanks to both of you, for opening the issue and for suggesting a possible fix, but sadly I need to put this issue on hold for the moment. I'm currently away from my desktop PC (which is the only machine I own with AMD graphics) and will stay this way for quite some time (~1 month), this means that -obviously- I won't be able to test anything on practice.

I might push something to the staging branch (nothing assured), but -again- it will be untested code.

Sorry for the inconvenience.

@igo95862
Copy link

igo95862 commented May 7, 2021

@zzkW35 Would you be able to merge Pull Requests?

@zzkW35
Copy link
Owner

zzkW35 commented May 7, 2021

@zzkW35 Would you be able to merge Pull Requests?

Yes, but only in the staging branch. I want to personally test the code before committing it to master.

@BillyDM
Copy link
Author

BillyDM commented May 7, 2021

That's okay, no rush. The old chestm007 repo on my system still works fine for now.

zzkW35 added a commit that referenced this issue May 9, 2021
… sleep"

This reverts commit 82649eb.

It may partially solve #2, I still need to come out with a proper way to set fan speed after resuming from sleep
@zzkW35
Copy link
Owner

zzkW35 commented May 9, 2021

@BillyDM I just reverted that one commit you pointed out, can you test the staging branch and let me know if you keep facing the issue?

While you're at it, can you share your PC specs?

Thanks.

@BillyDM
Copy link
Author

BillyDM commented May 10, 2021

@BillyDM I just reverted that one commit you pointed out, can you test the staging branch and let me know if you keep facing the issue?

While you're at it, can you share your PC specs?

Thanks.

I tried the staging branch and it did not fix the issue. So it seems that wasn't the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants