Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

fix for HandlerUtils.readCf #126

Merged
merged 2 commits into from Feb 27, 2013

Conversation

Projects
None yet
2 participants
Collaborator

jsanda commented Feb 27, 2013

Some of my previous changes introduced a regression around determining how to calculate the column name/value.

jsanda added some commits Feb 27, 2013

guard against NPEs
My previous changes to the readCf() method introduced some regressions around
the logic that determines how to calculate the column name and column value. I
needed to check if there is meta data for the column name and value. If and
only if there is meta data, the component value is calculated with a type
conversion; otherwise, we just take the raw byte buffer. Note that the
ByteBuffer cannot be stored as is in JsonObject. We need to get the bytes
which are in turn encoded. We might want to see about providing an alternate
implementation that will be more efficient, if that is possible.

zznate added a commit that referenced this pull request Feb 27, 2013

Merge pull request #126 from jsanda/readCf-fix
fix for HandlerUtils.readCf

@zznate zznate merged commit cb2755c into zznate:master Feb 27, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment