fix for HandlerUtils.readCf #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 27, 2013 11:15
My previous changes to the readCf() method introduced some regressions around the logic that determines how to calculate the column name and column value. I needed to check if there is meta data for the column name and value. If and only if there is meta data, the component value is calculated with a type conversion; otherwise, we just take the raw byte buffer. Note that the ByteBuffer cannot be stored as is in JsonObject. We need to get the bytes which are in turn encoded. We might want to see about providing an alternate implementation that will be more efficient, if that is possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of my previous changes introduced a regression around determining how to calculate the column name/value.