-
-
Notifications
You must be signed in to change notification settings - Fork 892
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Use attr keys when testing bulk update params for primary key
Fixed bug in :meth:`.Session.bulk_update_mappings` where alternate mapped attribute names would result in the primary key column of the UPDATE statement being included in the SET clause, as well as the WHERE clause; while usually harmless, for SQL Server this can raise an error due to the IDENTITY column. This is a continuation of the same bug that was fixed in 🎫`.3849`, where testing was insufficient to catch this additional flaw. Fixes: #4357 Change-Id: Iead058c0465dfa31c5b8a8780769278b7000acc8
- Loading branch information
Showing
3 changed files
with
78 additions
and
13 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
.. change:: | ||
:tags: bug, orm | ||
:tickets: 4357 | ||
|
||
Fixed bug in :meth:`.Session.bulk_update_mappings` where alternate mapped | ||
attribute names would result in the primary key column of the UPDATE | ||
statement being included in the SET clause, as well as the WHERE clause; | ||
while usually harmless, for SQL Server this can raise an error due to the | ||
IDENTITY column. This is a continuation of the same bug that was fixed in | ||
:ticket:`.3849`, where testing was insufficient to catch this additional | ||
flaw. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters