Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment support #284

Closed
wants to merge 1 commit into from
Closed

Comment support #284

wants to merge 1 commit into from

Conversation

RazerM
Copy link
Contributor

@RazerM RazerM commented Jun 12, 2016

Implementation of #1546 (BitBucket).

Very unfinished but I have reflection and setting after table creation working for PostgreSQL.

If you're not opposed, perhaps best to continue discussion on Gerrit?

@zzzeek
Copy link
Owner

zzzeek commented Jun 13, 2016

I'll pull it in now. But keep in mind, the SQLAlchemy 1.1 release is overflowing with features at this point and I'm desperately just trying to get the last few lingering pull requests that have been out there for a long time into it, for the moment the commenting support remains a lower priority so this would have to be targeted for either 1.1-midstream or a 1.2 (1.2 is preferred as we like to keep a minor release series free of big changes once released at this point).

@zzzeek
Copy link
Owner

zzzeek commented Jun 13, 2016

Dear contributor -

This pull request is being moved to Gerrit, at https://gerrit.sqlalchemy.org/111, where it may be tested and reviewed more closely. As such, the pull request itself is being marked "closed" or "declined", however your contribution is merely being moved to our central review system. Please register at https://gerrit.sqlalchemy.org#/register/ to send and receive comments regarding this item.

@zzzeek zzzeek closed this Jun 13, 2016
zzzeek pushed a commit that referenced this pull request Jul 6, 2016
Implementation of [#1546 (BitBucket)](https://bitbucket.org/zzzeek/sqlalchemy/issues/1546).

Very unfinished but I have reflection and setting after table creation working for PostgreSQL.

If you're not opposed, perhaps best to continue discussion on Gerrit?

Change-Id: Ib90683850805a2b4ee198e420dc294f32f15d35d
Pull-request: #284
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants