Add naming convention support when using schema in the metadata. #67
Conversation
|
I'm new to watching this project and so I apologize if this is really obvious, but can you think of a case where this would happen? I'm just curious if this is something that should be caught in automation. Tuple unpacking errors raise a fatal error in Python so I imagine that if this was an existing bug that we might want to increase coverage here. |
|
well you can have schema on table or metadata. I plan on creating a test for this right now before I merge this pull. |
|
Good to know, thanks! And here I was hoping to write one first. ;) |
|
OK well I usually don't have much help and I'm also super-impatient so especially when a feature I just wrote is already broken, I move really fast (I do the GTD philosophy where if it takes less than 2 minutes, do it right now, else things pile up). But I'm actually terrible at running more of a team-based project in this regard, so, if you plan on being around, I need to work at letting you in. |
|
Absolutely! Was meant as a helpful jest and nothing more. |
|
yeah, but it is a real problem, I've tried to run sprints at pycon and such and often it didn't go too well (tried to get people to help with docs. not fun enough! well ok). the test + changelog I did here is in c5dccd8. |
|
oh and thanks to @farvour ! |
|
You're welcome. Sorry I didn't have time to get any tests written. I just wanted to be able to use the new feature with schemas! :) |
If the metadata contains a schema, the target_fullname is schema.table.column. Added a check to see if the 3rd element exists to handle this situation.