fix for #48 End tag removed when option tag found in html

zzzprojects · Jul 31, 2017 · bc0dd47 · bc0dd47
1 parent f5a9108
commit bc0dd47
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 1 deletion.
diff --git a/src/HtmlAgilityPack.Tests/HtmlDocumentTests.cs b/src/HtmlAgilityPack.Tests/HtmlDocumentTests.cs
@@ -548,5 +548,15 @@ public void TestFormTag()
             Assert.AreEqual(document.DocumentNode.OuterHtml, html);
             Assert.AreEqual(result.Count(), 1);
         }
+        [Test]
+        public void TestOptionTag()
+        {
+            var html = "<select><option>Select a cell</option><option>C1</option><option value='\"c2\"'></select>";
+
+            string output = "<select><option>Select a cell</option><option>C1</option><option value='\"c2\"'></option></select>";
+            var document = new HtmlDocument();
+            document.LoadHtml(html);
+            Assert.AreEqual(document.DocumentNode.OuterHtml, output);
+        }
     }
 }
diff --git a/src/HtmlAgilityPack/HtmlDocument.cs b/src/HtmlAgilityPack/HtmlDocument.cs
@@ -1055,6 +1055,8 @@ private string[] GetResetters(string name)
                 case "td":
                     return new string[] {"tr", "table"};
 
+                case "option":
+                    return new string[] { "select", "optgroup", "datalist" };
                 default:
                     return null;
             }

diff --git a/src/HtmlAgilityPack/HtmlNode.cs b/src/HtmlAgilityPack/HtmlNode.cs
@@ -109,7 +109,7 @@ static HtmlNode()
 			ElementsFlags.Add("form",  HtmlElementFlag.CanOverlap);
 
 			// they sometimes contain, and sometimes they don 't...
-			ElementsFlags.Add("option", HtmlElementFlag.Empty);
+			//ElementsFlags.Add("option", HtmlElementFlag.Empty);
 
 			// tag whose closing tag is equivalent to open tag:
 			// <p>bla</p>bla will be transformed into <p>bla</p>bla