Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XML processing instruction(s) are classified as a textnode? #309

Closed
chadwood opened this issue Jul 1, 2019 · 5 comments
Closed

XML processing instruction(s) are classified as a textnode? #309

chadwood opened this issue Jul 1, 2019 · 5 comments
Assignees

Comments

@chadwood
Copy link

chadwood commented Jul 1, 2019

I'm not sure if this is a bug or not. I don't believe XML processing instructions should be classified as a text node. I want to exclude these.

https://dotnetfiddle.net/4RXN2i

@JonathanMagnan JonathanMagnan self-assigned this Jul 1, 2019
@JonathanMagnan
Copy link
Member

You are right, it seem there is an issue

<?foo note=""I am XML processing instruction. I wish to be excluded"" ?> should become a comment as it is processed by Chrome and Safari.

Best Regards,

Jonathan


Performance Libraries
context.BulkInsert(list, options => options.BatchSize = 1000);
Entity Framework ExtensionsEntity Framework ClassicBulk OperationsDapper Plus

Runtime Evaluation
Eval.Execute("x + y", new {x = 1, y = 2}); // return 3
C# Eval FunctionSQL Eval Function

@chadwood
Copy link
Author

chadwood commented Jul 1, 2019

Is this something that could be squeezed into the next release? I have a workaround in place for dealing with these. But it's part of the html-agility-pack code base.

@JonathanMagnan
Copy link
Member

There is a good chance it will be part of next release but I'm not sure if that will happen this week or next week.

@JonathanMagnan
Copy link
Member

Hello @PokerPro123 ,

A new version has been released v1.11.9, this part of the text is now considered as a comment (like the browser does).

Let me know if everything works as expected.

@chadwood
Copy link
Author

Thanks! I'll report back in a day or two. I need to catch up on a couple other tasks first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants